Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify creating and editing a plant #307

Open
8 tasks
niccokunzmann opened this issue Sep 23, 2019 · 0 comments
Open
8 tasks

clarify creating and editing a plant #307

niccokunzmann opened this issue Sep 23, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@niccokunzmann
Copy link
Owner

niccokunzmann commented Sep 23, 2019

@Heineken identified the following behavior to bring clarity to when a plant is created. For a discussion, see #299.

  • When I edit an existing plant, there is a button named "Delete". When I press it, the plant is gone.
  • When I open a new plant from the map, there is a button named "Cancel". When I press it, the plant is gone.
  • When I open a new plant from the list of my plants, there is a button named "Cancel". When I press it, the plant is gone.
  • When I edit an existing plant and I press the back button, no changes are applied to the data or, if changes have been applied immediately while editing, they are reverted.
  • When I open a new plant from the map, when I press the back button, the plant is gone.
  • When I open a new plant from the list of my plants, when I press the back button, the plant is gone.
  • When changes are discarded, there is a dialog informing about this and one can cancel discarding the changes.
  • When a plant is deleted, a dialog asks if the plant should really be deleted.

Source code:

  • Mainly: NewPlantActivity.java
  • to switch between "create" and "edit", one can either subclass or use if/else or use a strategy pattern

We're using [Polar.sh](https://polar.sh/niccokunzmann) so you can upvote and help fund this issue. We receive the funding once the issue is completed & confirmed by you. Thank you in advance for helping prioritize & fund our work. Fund with Polar
@niccokunzmann niccokunzmann changed the title clarify creating a new plant clarify creating or editing a plant Sep 23, 2019
@niccokunzmann niccokunzmann changed the title clarify creating or editing a plant clarify creating and editing a plant Sep 23, 2019
@niccokunzmann niccokunzmann added the enhancement New feature or request label Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant