Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choose google or openstreetmap or none as address search #23

Open
niccokunzmann opened this issue Feb 17, 2019 · 2 comments
Open

choose google or openstreetmap or none as address search #23

niccokunzmann opened this issue Feb 17, 2019 · 2 comments

Comments

@niccokunzmann
Copy link
Owner

niccokunzmann commented Feb 17, 2019

Events have addresses. These can be searched for by google maps, openstreet map, none at all.
Please provide an option to the user. Default should be openstreetmap.


We're using [Polar.sh](https://polar.sh/niccokunzmann) so you can upvote and help fund this issue. We receive the funding once the issue is completed & confirmed by you. Thank you in advance for helping prioritize & fund our work. Fund with Polar
@thoka
Copy link

thoka commented Feb 17, 2019

As I understand this is an user interface option in contrast to #28.
Make it also configurable in the settings file.

We have to discuss, whether this opens up vulnerability holes, if one allows to add any URLs in the (remote) setting file.

But, as any creator of a web infrastructure always have the ability to send evil code, this seems to be an minor issue.

@niccokunzmann
Copy link
Owner Author

We have to discuss, whether this opens up vulnerability holes, if one allows to add any URLs in the (remote) setting file.
But, as any creator of a web infrastructure always have the ability to send evil code, this seems to be an minor issue.

I also think, this is a minor issue. But who knows^^

As I understand this is an user interface option in contrast to #28.

This is a requirement for all options:

  • configuration via the index page
  • documentation of the option on the index page
  • loadable via query parameters
  • loadable via JSON calendar specification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants