Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If using fallback, should stop respecting the interval period #9

Closed
nicholaschiasson opened this issue Jul 23, 2020 · 2 comments
Closed
Labels
enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right

Comments

@nicholaschiasson
Copy link
Owner

The fallback becomes the peer to use in the case of DNS resolution failure. In many cases, this can be due to a sporadic failure, thus it becomes undesirable to use the fallback address for the full interval duration. Allowing one or a few errors is acceptable, but allowing errors for several seconds, possibly minutes, due to an interval configured to match a DNS TTL, this can be very bad.

In the case where the fallback address is being used, we should attempt the DNS resolution until it succeeds.

@nicholaschiasson nicholaschiasson added enhancement New feature or request help wanted Extra attention is needed labels Jul 23, 2020
@nicholaschiasson
Copy link
Owner Author

Perhaps also this could be configurable. We could add another boolean attribute to the directive like fallback_recover, which when true (present), we use the behaviour I described above, otherwise if not present, then we continue with the current behaviour. I think this would be the best solution.

@nicholaschiasson
Copy link
Owner Author

Superseded by #10

@nicholaschiasson nicholaschiasson added the invalid This doesn't seem right label Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant