Items stay in your inventory after server restart when using multi window

[Tuchan]

Whenever you use a multi window and the server crashes, the items don't get restored after joining back.

Since the contents are already saved and restored...

...would it be possible to serialize and save the player's inventory in a file (maybe datebase even) upon the server close?

InvUI/invui-core/src/main/java/xyz/xenondevs/invui/window/AbstractDoubleWindow.java

Line 26 in f768962

private final ItemStack[] playerItems = new ItemStack[36];

This way, whenever a player joins back, it would see if the inventory was restored. If not, deserialize the data and:

InvUI/invui-core/src/main/java/xyz/xenondevs/invui/window/AbstractDoubleWindow.java

Lines 64 to 69 in f768962

	private void restorePlayerInventory() {
	Inventory inventory = getViewer().getInventory();
	for (int i = 0; i < 36; i++) {
	inventory.setItem(i, playerItems[i]);
	}
	}

[Tuchan]

Can still reproduce on v1.26

[NichtStudioCode]

Can you send a minimal reproducible example, along with the server software version you're using?

[Tuchan]

Thanks GitHub for giving me a notification............. sorry....
(please ping me next time)

https://pastebin.com/C8iDej2j
server version: paper-1.20.2-318.jar

[NichtStudioCode]

@Tuchan
Also works fine for me.
Both stopping the server and letting it be stopped by the watchdog thread call plugin disable, which closes the inventories.

[Tuchan]

Apparently, 3 out of 4 server instances are broken somehow and this feature doesn't work on them, but a completely fresh install of paper is fine. This is a user error. Sorry for the trouble.