-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GNOME 43 #30
Comments
👍 Works great on Gnome 42. Waiting support for Gnome 43. Thanks. |
I got it "working" on 43. I did a couple of things, I am not exactly sure what got it to work. And I am wondering if I really got it work in 43 or if the ctrl alt tab + arrow keys I now have are maybe an update to the stock osk for Gnome 43. I did do the following + maybe they will work for others.
|
Yep, good guess, that was the built-in OSK. Gnome 43 added a terminal mode to the default OSK that includes Ctrl, Alt, Tab and arrow keys, but it only shows when you're using terminal. This extension used to rewrite quite a few methods of the default OSK, and that made maintaining it rather difficult. At this point, I'm considering rewriting it to make use of the "terminal mode" and extended keyboard layout that was added in Gnome 43. However, I'd have to test everything, and manually create and package extended OSK layouts for each language, so it'll take some time to get it working. If you really need an extended OSK in Gnome 43 right now, there's a WIP branch here: https://github.com/nick-shmyrev/improved-osk-gnome-ext/tree/gnome_43_rewrite. Basically, it replaces the default US layout with an extended one made for a terminal mode. I've briefly tested it in Fedora 37 Beta, and it seems to be working. However, it currently lacks F1-12 buttons, Escape and Super keys, doesn't support any key combinations using Shift, and only shows additional keys for US layout. To install it, you'll need to clone that branch, and copy the files into the extension dir ( |
@nick-shmyrev: Thanks for your work. I'm still on Gnome 42 because my distribution hasn't provided the Gnome 43 version yet. I'm not in a hurry because I'm waiting for all the gnome extensions I use to be available under Gnome 43, including yours. |
hi, on Debian testing here, Gnome-shell 43.1 |
Is there an ETA? Fedora 37 stable just got released, but I would like to wait until this gets updated since I have a thinkpad yoga and really need this extension. |
I am typing this on a tablet with Fedora 37. Using a physical keyboard. I would like the keyboard to have the extra keys I'm used to, and not only for input to Gnome Terminal. For example, I use them in FireFox. Your extension seems to do this. I would like the keyboard to be smaller, sized to the actual buttons, and to be able to be dragged around. That would interfere less with viewing what's on the screen. ChromeOS seems to have this. Thanks! |
Man, I should not have upgraded to 43. The default osk is wet hot trash. Difficult to use on my tablet, numbers are buried and it works poorly. I am eagerly waiting for your osk to update, it's a ferrari where as the ubuntu osk is a goat pulled cart with square wheels. My surface 3 pro is hamstrung because the default osk is soooo bad |
Check out Onboard, if I recall correctly it was draggable. |
Thanks for the pointer. https://github.com/schuhumi/gnome-shell-extension-onboard-integration Unfortunately it was last updated six years ago. It supports Gnome 3.20 so I imagine that it won't work now. It looks as if the meat of it is only 80 lines of Javascript so it might be easy to fix but I know nothing about how Gnome Shell Extensions work. |
There's an updated version of the extension available at https://github.com/nick-shmyrev/improved-osk-gnome-ext/tree/gnome_43_rewrite. It's still a work-in-progress, but it now has extended keys for US, FR, DE, ES, RU and UA layouts. If the layout you're using is not included, let me know, and I'll add it. Or, feel free to modify it yourself (see /src/data/osk-layouts dir) and make a PR. To install extension, clone the gnome_43_rewrite branch, run
Known issues:
|
Hello, I've just now installed the Gnome 43 rewrite of Improved OSK on my Arch system, using it on my (rather elderly) Dell Venue 11 Pro tablet. It certainly lives up to its name - I realise it's still WIP, but it's much better than the default Gnome OSK (which is itself quite nice)! Just the fact of being able to make the keyboard bigger on landscape mode is an absolute godsend; my relatively fat fingers say "Thank you!" :) Just a couple of things I wanted to say. Firstly - Nick: this extension is awesome! I wanted to encourage you to keep up the great work; happy to help in any way I can (testing etc). Sadly I don't have any coding experience to speak of, otherwise I'd help with that too.
That is correct, however Onboard is pretty clunky on Gnome, particularly on Wayland. Which is a pity really, as in itself it's a fantastic on-screen keyboard. Input from Onboard does not come up in a Wayland session. |
Hi, thanks a lot for your work. I installed gnome_43_rewrite. While being very helpful, I just wanted to notify you, that ctrl-click (e.g. to select multiple mails in evolution) doesn't work currently. It did in Gnome 42. Would be very nice if this functionality could come back. Let me know if I can help you with testing. Thanks a lot! |
I don't know what's wrong with what I am doing:
and the only thing I get is the keyboard icon on the traybar. |
@sughero aside from the IT layout not being fully supported yet, as you correctly mentioned, you should also avoid cloning the 43 branch into |
@yfreund thanks, you're right! |
@sughero I'm glad you've found a solution that works for you, at least for now. Which device are you using the extension on?
|
Well, that's far from being a "solution", let's say it's a work around
I am using it on a Microsoft Surface book 2. Everything was perfect on gnome 42 and accessibility set on on was not required
You can completely detach screen and use it as a tablet but you can also connect screen reverse-wise using keyboard as a "standing support"
I will definitevely try your code and let you know what works, thanks again. |
Fair enough.
I am familiar with the Surface Book series, though I've never owned one. I am a bit surprised that this extension isn't working for you "as is" when used without the keyboard attached, but unfortunately there are constant changes to upstream GNOME (specifically I should note that the OSK behavior is also inconsistent between
That's great - the more testing to my alterations, the better. I really hope this works better for yo than the accessibility setting, as I was having a similar issue with my setup before I ran into the additional extension, and prompted me to add the code to this extension once it was no longer maintained. If you don't mind, I'd suggest we move this discussion to the pull request once you give my fork a try - it feels like we're going a bit off-topic in our discussion. |
@sughero I've updated IT layout to also include extended keys, so at least you won't have to change layouts to use CTRL and ALT anymore. |
thanks :) |
A version supporting Gnome 43 is now available at https://extensions.gnome.org/extension/4413/improved-osk/. Currently, the following layouts have extended keys: CH+FR, CH, DE, ES, FR, IT, RU, UA, US. If the layout you're using does not have the extended keys, let me know, and I'll add them. Or, feel free to modify it yourself (see /src/data/osk-layouts dir) and make a PR. It also includes a fix for Numbers layer not properly latching. |
Can most of the rewrite be reused for the gnome 44 release. Gnome 44 comes out on the 22. It would be great If I can the latest fedora when it comes out. According to this, The planned release date of fedora 38 is 25.04.2023. |
https://os.gnome.org/ is already available and should allow testing the extension on 44 right away |
Describe the bug
The extension doesn't work on GNOME 43.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The extension works on GNOME 43.
Screenshots
![Screenshot from 2022-09-22 19-48-09](https://user-images.githubusercontent.com/1403194/191864628-f5358bb7-c27f-45cf-abff-e937620c04bb.png)
Environment (please complete the following information):
Additional context
I have been running my system for a while.
No.
journalctl /usr/bin/gnome-shell -f -o cat
show any errors?No.
Alt + F2
, enterlg
, switch to "extensions" tab and click "show errors" for Improved OSK extension)No.
The text was updated successfully, but these errors were encountered: