Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is 'rlang' a dependency? #8

Closed
clarkfitzg opened this issue Jul 12, 2019 · 1 comment
Closed

Is 'rlang' a dependency? #8

clarkfitzg opened this issue Jul 12, 2019 · 1 comment

Comments

@clarkfitzg
Copy link
Contributor

rstatic uses package rlang, but doesn't mention it in DESCRIPTION.

clarkf@poisson ~/dev/rstatic (master)
$ grep -r "rlang::" *
R/utilities.R:  dots = rlang::quos(...)
R/utilities.R:    if (rlang::quo_is_missing(elt))
R/utilities.R:      rlang::eval_tidy(elt)
@nick-ulle
Copy link
Owner

Yes. I was reluctant to add another dependency, but couldn't find any straightforward base R way to collect arguments to ... when some of them are missing.

I've added rlang to the imports and fixed a bug in the related code in 478f7af.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants