Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Fixture setup with arguments #24

Open
Lectem opened this issue May 29, 2015 · 6 comments
Open

Fixture setup with arguments #24

Lectem opened this issue May 29, 2015 · 6 comments

Comments

@Lectem
Copy link
Contributor

Lectem commented May 29, 2015

I was trying to create a fixture so that the size of the input of the test would be different among benchmarks, but with the same fixture.

Hawai doesn't do well with template fixtures, I expected as much. However I think it would be interesting to give SetUp, TearDown etc a void* parameter so that we can configure those steps per benchmark.

@nickbruun
Copy link
Owner

This is a good point; I've been pondering templated benchmarks myself. I'll add this to the work of getting a version 1.0.0 out there :)

@nickbruun nickbruun added this to the Version 1.0.0 milestone May 29, 2015
@Lectem
Copy link
Contributor Author

Lectem commented May 29, 2015

Templated benchmarks could be useful (especially with c++11 variadic templates). But I think it shouldn't depend too much on c++11, or at least have the non-c++11 features still backward-compatible.
Using lambdas as SetUp/TearDown could also be interesting

@nickbruun
Copy link
Owner

Yea, dependency on C++11 is not something I'm comfortable with. However, enabling more powerful features when C++11+ is used makes sense.

@MariusHerget
Copy link

Are there any news about this topic?

@pdroalves
Copy link

Was this implemented yet?

@nickbruun
Copy link
Owner

Not yet, no. We might want to drop C++<11 support and do this :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants