Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for .c++ file extension #99

Closed
tobbelobb opened this issue May 21, 2020 · 2 comments
Closed

Support for .c++ file extension #99

tobbelobb opened this issue May 21, 2020 · 2 comments

Comments

@tobbelobb
Copy link

Hello Compiledb developers!

Could we change

file_regex = re.compile(r"^.+\.c$|^.+\.cc$|^.+\.cpp$|^.+\.cxx$|^.+\.s$", re.IGNORECASE)

into

file_regex = re.compile(r"^.+\.c$|^.+\.cc$|^.+\.cpp$|^.+\.cxx$|^.+\.c\+\+$|^.+\.s$", re.IGNORECASE)

please please pleeeease?

I know .c++ is not a widely used file extension, but if you ever see it in the wild, you would expect the file to contain c++ source code and nothing else, right?

@Thaodan
Copy link

Thaodan commented Nov 9, 2020

PR?

@tobbelobb
Copy link
Author

Ok, created one: #108

Closing this issue, we can keep further comments in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants