Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard on 2.2.5 - Major bug - Broken extension #9

Closed
nitriques opened this issue Jun 12, 2012 · 5 comments
Closed

Dashboard on 2.2.5 - Major bug - Broken extension #9

nitriques opened this issue Jun 12, 2012 · 5 comments

Comments

@nitriques
Copy link
Member

Github API v2 now returns 404 since it has been replaced by v3.

Now the dashboard is broken on every v2.2.x site I have in production.

What approach do you want to use to fix this?
I may be able to commit a patch tonite.

@nitriques
Copy link
Member Author

I found it:

https://github.com/api/v2/json/repos/show/symphonycms/symphony-2/tags

should become

https://api.github.com/repos/symphonycms/symphony-2/tags

And some changes had to be made in the for loop

$repo_tags = json_decode(@file_get_contents('https://api.github.com/repos/symphonycms/symphony-2/tags'));
$tags = array();

foreach($repo_tags as $tag) {
    // remove tags that contain strings
    if(preg_match('/[a-zA]/i', $tag->name)) continue;
    $tags[] = $tag->name;
}

@TheJester12
Copy link

I can confirm that this is an issue, I had a few sites break tonight (seems to only effect installs older than 2.2.5?).

nitriques' patch worked for me.

@nickdunn
Copy link
Contributor

Ah they finally switched it off. I spent a long time updating the Symphony Extensions site last month but I forgot that this extension also called the API.

The quickest fix would be to remove the Symphony Overview panel from your builds, not such an issue since it's not particularly useful all of the time. I'll roll this into the latest version of the extension, which is 2.3-compatible only.

@nitriques
Copy link
Member Author

Great @nickdunn .

Please consider patching the lastest tag compatible with 2.2.x.
I have a lot of website that won't get updated to 2.3 and I have still a few in development that won't get updated too.

nitriques added a commit to DeuxHuitHuit/dashboard that referenced this issue Oct 15, 2012
@nitriques
Copy link
Member Author

Fixed in the master branch

brendo added a commit that referenced this issue Aug 5, 2013
Update for GitHub API v3. Fixes #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants