Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future of this crate #15

Open
TileHalo opened this issue Jan 1, 2016 · 1 comment
Open

Future of this crate #15

TileHalo opened this issue Jan 1, 2016 · 1 comment

Comments

@TileHalo
Copy link
Contributor

TileHalo commented Jan 1, 2016

Hi!

There are many issues with this crate, latest one not being able to compile Silmukka, since in uses this crate and nickel_cookies crate.

Error Message

native library `openssl` is being linked to by more than one version of the same package, but it can only be linked once; try updating or pinning your dependecies to ensure that this package only shows up once

  openssl-sys v0.7.4
  openssl-sys v0.6.7

This is the main problem I faced and it was easy to fix: remove openssl from nickel_postgres.

Other problems are lack of crates.io package, according to example using crate requires importing many crates (r2d2, postgres, not nickel), which are already present in nickel_postgres.

Is this crate being actively developed, or planned to be? Since I have to fix some of these for Silmukka, should I bother making pull requests?

@Ryman
Copy link
Member

Ryman commented Jan 7, 2016

Other problems are lack of crates.io package, according to example using crate requires importing many crates (r2d2, postgres, not nickel), which are already present in nickel_postgres.

Sorry, I don't fully understand this line.

Is this crate being actively developed, or planned to be? Since I have to fix some of these for Silmukka, should I bother making pull requests?

I think a lot of the functionality of this library is less useful with unboxed closures or even the shared ServerData that was added to nickel, where the library could at least enforce some constraints at compile time by using that (similar to how session/cookie work)

I'm happy to review and merge PRs, I think this library could do with a lot of love and I haven't personally seen to it as much as I've wanted to :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants