Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import 'active_support' before any of its subparts #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Import 'active_support' before any of its subparts #41

wants to merge 1 commit into from

Conversation

godric
Copy link

@godric godric commented Mar 1, 2022 •
edited

TL;DR, Fix compatibility with ActiveSupport >7 which now require "active_support" before anything else

What?

  • Add require "active_support" before any other active_support requires

Why?

  • Fixes Issue with Rails 7.0.1 #40
  • This issue has been brought to the attention to Rails maintainers, as it has broken a few gems.
    see this reply from the maintainers

    you must require "active_support" before requiring any subparts. That may change in the future, but for now that's the fix you are looking for.

  • ActiveSupport since v7 auto-loads (lazy-load) all its constants here

@mkonecny
Copy link

@nickelser any chance we get this change in?

@godric
Copy link
Author

godric commented Aug 8, 2023

Closing because this does not seem to be an issue anymore in up to date ActiveRecord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with Rails 7.0.1
2 participants
@godric @mkonecny