Hiding view modifier with custom transitions #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR! I’ll take a look this weekend. |
nickffox
reviewed
Mar 28, 2020
Comment on lines
+12
to
+14
| /// - Warning: A Keyboard must be available in the Environment. | ||
| /// - Parameter transition: Transition which will be used to hide or show the view during keyboard presentation. By default it animated opacity. | ||
| /// - Returns: A view which is empty if keyboard is visible. |
…eature/hiding-modifier * 'master' of github.com:nickffox/KeyboardObserving: Update file header comment. (#15)
|
Thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was experimenting with your library and found one use-case it currently doesn't solve.
When you want some view to react on keyboard change with custom transition, you cannot currently do it. I iterated on the solution by @jaywardell, which always animated opacity. And I reimplemented it using view modifier.
Here is a typical use-case. I want to move some view out of the screen when keyboard appears:
How to use it:
Let me know what you think about the solution.