Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acfv5 compatibility #2

Merged
merged 2 commits into from Jun 20, 2016

Conversation

dpellenwood
Copy link
Contributor

Updates the plugin for ACF v5 and adds a few compatibility tweaks.

@nickforddev
Copy link
Owner

Thanks for your PR!

Finally got a chance to test this out, I'm seeing a problem and having a hard time debugging it.

wp_register_script( 'acf-input-swatch', $this->settings['dir'] . 'js/min/input-min.js', array('acf-input'), $this->settings['1.0.0'] );

I get 404s when editing a post that uses the plugin, the path returned from $this->settings['dir'] appears to be the full path to acf-swatch-v5.php... So the path to the JS appears as such:

.../wp-content/plugins/acf-swatch/acf-swatch-v5.phpjs/min/input-min.js?ver=4.6-alpha-37746

I'm trying to debug this, but it's been a while since I've worked in PHP. Any idea whats going on there?

@dpellenwood
Copy link
Contributor Author

Hi Nick,

Thanks for the feedback. That issue is from the current public version of the plugin. My PR actually fixes that. See this line in my commits. I update the settings dir URLs, etc to make sure that they properly reference the correct locations.

Are you sure you're testing the acf5-compatibility branch?

@nickforddev nickforddev merged commit 0b1b7f6 into nickforddev:master Jun 20, 2016
@nickforddev
Copy link
Owner

...right you are! PR accepted, thank you @dpellenwood!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants