Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendor/nicklasw/pkm-go-api/src/Api/Pokemon/Data/PokemonMetaRegistry.php #165

Closed
xmillies opened this issue Dec 30, 2016 · 6 comments

Comments

@xmillies
Copy link

The pokemon meta registry needs to be updated with new pokémons :

Notice: Undefined offset: 174 in C:\WTServer\WWW\pogo\vendor\nicklasw\pkm-go-api\src\Api\Pokemon\Data\PokemonMetaRegistry.php on line 26

Where do you take previous data ?

@NicklasWallgren
Copy link
Owner

@xmillies The information comes from the GAME_MASTER file https://gist.github.com/elfinlazz/5c7e33be1292329f61f1023a79251cc3

Anyone up for the task?

@voxx
Copy link
Contributor

voxx commented Dec 31, 2016

Here yah go.

Two attachments.

  1. A script used to parse the json and output the relevant php.
  2. The additional php objects to add to PokemonMetaRegistry.php

export-meta.php.txt

PokemonMetaRegistry.php.txt

@NicklasWallgren
Copy link
Owner

@voxx Nice addition 👍 Could you update the PokeMetaRegistry and make a pull request? :)

@voxx
Copy link
Contributor

voxx commented Dec 31, 2016

@NicklasWallgren PR created as requested.

-> #168

@NicklasWallgren
Copy link
Owner

Resolved by @voxx

@NicklasWallgren
Copy link
Owner

Fixed a minor issue with suffixes.

2e95538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants