Supporting two controls for engine #2
Conversation
|
This looks great, thanks! I'll do a thorough review when I get a chance, but just a couple of preliminary thoughts:
|
There was a problem hiding this comment.
Awesome work! I have a few suggestions to simplify the code, but functionality-wise it's perfect, and it's certainly much nicer to play the game with strafing!
I'll cover dual stick controls in a future tutorial, but in the meantime this PR is a great example - thanks!
| } else { | ||
| rotation = Rotation(sine: sine, cosine: cosine) | ||
| } | ||
| player.velocity = input.speed.rotated(by: rotation) * player.speed | ||
| player.position += player.velocity * timeStep |
There was a problem hiding this comment.
This can be simplified to the following:
mutating func update(timeStep: Double, input: Input) {
player.direction = player.direction.rotated(by: input.rotation)
let forwardVelocity = player.direction * input.speed.x * player.speed
let strafingVelocity = player.direction.orthogonal * input.speed.y * player.speed
player.velocity = forwardVelocity + strafingVelocity
player.position += player.velocity * timeStep
while let intersection = player.intersection(with: map) {
player.position -= intersection
}
}Having to useinput.speed.x for forward motion and input.speed.y for strafing is a little confusing, but it's because you're passing leftInputVector.orthogonal as the input speed in ViewController (see below).
| let input = Input( | ||
| speed: -inputVector.y, | ||
| speed: leftInputVector.orthogonal, |
There was a problem hiding this comment.
If you change this to speed: Vector(x: leftInputVector.x, y: -leftInputVector.y) then you can swap input.speed.x and input.speed.y in the World.update() code above, which I think would be more intuitive.
Source/Rampage/ViewController.swift
Outdated
| return imageView | ||
| }() | ||
|
|
||
| private let leftJoyStick = UIView() |
There was a problem hiding this comment.
I would suggest you create a new UIView subclass called JoystickView (or whatever) and move all of the gesture logic into that, so that you only need to create two view instances in the view controller instead of two copies of everything.
|
@akbashev sorry this was auto-closed when I restructured the project after the latest update and I can't reopen it because the history no longer matches up. Please rebase and re-open it when you get a chance, thanks! |
|
@nicklockwood hello! first of all thx for quick response :) and no problem, I'm a bit busy, but will try to do it by tomorrow evening... |
|
@akbashev do you still plan to update your PR? Otherwise I might create one myself. |
|
@nicklockwood sorry I was very busy last several months. What is the status now, should I update pull request or it's already done? |
|
@akbashev it's not been done yet. |
This adds two controls support to engine.
It's really hard to move
Playerwith just one control on mobile phones. Better would be supporting two controls — one for rotation and the other one for movement.For this purposes this change adds:
Inputspeed property to a vector;Worldto move according newInput.Kinda hard part is that movement should be always adjusted to direction. For this I calculate the rotation of direction from initial position and adjust speed vector. Straightforward, but works.