Make all extensions public so they're accessible via frameworks #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses issue #15, "Make extensions public." - All extensions are made public, so they can be referenced when VectorMath is added to a project as a framework via Cocoapods. - Extensions that declare conformance to Hashable are broken out as separate extensions, because extensions that declare protocol conformance cannot be declared public. - The explicit definition of Scalar.pi is removed, because Swift already declares it as Float.pi and Double.pi. When VectorMath is added to a project as a framework and Scalar.pi is referenced, the duplicate definition of pi causes a compiler error about ambiguous symbols.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses issue #15, "Make extensions public."
All extensions are made public, so they can be referenced when
VectorMath is added to a project as a framework via Cocoapods.
Extensions that declare conformance to Hashable are broken out as
separate extensions, because extensions that declare protocol
conformance cannot be declared public.
The explicit definition of Scalar.pi is removed, because Swift
already declares it as Float.pi and Double.pi. When VectorMath is
added to a project as a framework and Scalar.pi is referenced, the
duplicate definition of pi causes a compiler error about ambiguous
symbols.