Skip to content

Commit

Permalink
Updated to version 1.7.2
Browse files Browse the repository at this point in the history
  • Loading branch information
nicklockwood committed Jan 14, 2013
1 parent b883721 commit 11514ee
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 27 deletions.
18 changes: 4 additions & 14 deletions Examples/Zero Config Demo/Classes/iRateAppDelegate.m
Expand Up @@ -8,7 +8,6 @@

#import "iRateAppDelegate.h"
#import "iRateViewController.h"
#import "iRate.h"


@implementation iRateAppDelegate
Expand All @@ -21,18 +20,14 @@ @implementation iRateAppDelegate
//the app details are retrieved directly
//from iTunes using the app's bundle ID

//NOTE: you won't actually see anything until you've had the example installed
//for 10 days and launched it 10 times. You can simulate this by adjusting
//the date on your device if you wish to verify that it works


#pragma mark -
#pragma mark Application lifecycle

+ (void)initialize
{
//ok, we'll enable preview mode just so
//you can see something without waiting for
//ten days, but in the real app, you don't need this
[iRate sharedInstance].previewMode = YES;
}

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
// Add the view controller's view to the window and display.
Expand All @@ -42,9 +37,4 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
return YES;
}

#pragma mark -
#pragma mark Memory management



@end
Expand Up @@ -220,6 +220,7 @@
GCC_PREPROCESSOR_DEFINITIONS = "DEBUG=1";
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
INFOPLIST_FILE = "ZeroConfig-Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 6.0;
PRODUCT_NAME = ZeroConfig;
};
name = Debug;
Expand All @@ -234,6 +235,7 @@
GCC_PREFIX_HEADER = ZeroConfig_Prefix.pch;
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
INFOPLIST_FILE = "ZeroConfig-Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 6.0;
PRODUCT_NAME = ZeroConfig;
VALIDATE_PRODUCT = YES;
};
Expand Down
2 changes: 1 addition & 1 deletion LICENCE.md
@@ -1,6 +1,6 @@
iRate

Version 1.7, November 24th, 2012
Version 1.7.2, January 14th, 2013

Copyright (C) 2011 Charcoal Design

Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -256,7 +256,7 @@ This is called when the user declines to rate the app. This is useful if you wan

This is called when the user asks to be reminded to rate the app. This is useful if you want to log user interaction with iRate. This method is only called if you are using the standard iRate alert view prompt and will not be called automatically if you provide a custom rating implementation.

- (BOOL)iRateShouldopenAppStore;
- (BOOL)iRateShouldOpenAppStore;

This method is called immediately before iRate attempts to open the app store, either via a URL or using the StoreKit in-app product view controller. Return NO if you wish to implement your own ratings page display logic.

Expand Down
5 changes: 5 additions & 0 deletions RELEASE NOTES.md
@@ -1,3 +1,8 @@
Version 1.7.2

- Added dutch translation
- iRate now displays the StoreKit product view controller correctly even if a modally presented view controller has been displayed

Version 1.7.1

- Fixed deprecation warning when targeting iOS6 as the base target
Expand Down
24 changes: 13 additions & 11 deletions iRate/iRate.m
@@ -1,7 +1,7 @@
//
// iRate.m
//
// Version 1.7.1
// Version 1.7.2
//
// Created by Nick Lockwood on 26/01/2011.
// Copyright 2011 Charcoal Design
Expand Down Expand Up @@ -366,10 +366,7 @@ - (BOOL)shouldPromptForRating
//preview mode?
if (self.previewMode)
{
if (self.verboseLogging)
{
NSLog(@"iRate preview mode is enabled - make sure you disable this for release");
}
NSLog(@"iRate preview mode is enabled - make sure you disable this for release");
return YES;
}

Expand Down Expand Up @@ -848,14 +845,24 @@ - (void)openRatingsPageInAppStore
rootViewController = window.rootViewController;
}
if (!rootViewController)
{
UIWindow *window = [UIApplication sharedApplication].keyWindow;
rootViewController = window.rootViewController;
}
if (!rootViewController)
{
if (self.verboseLogging)
{
NSLog(@"iRate couldn't find root view controller from which to display StoreKit product screen");
NSLog(@"iRate couldn't find root view controller from which to display StoreKit product page");
}
}
else
{
while (rootViewController.presentedViewController)
{
rootViewController = rootViewController.presentedViewController;
}

//present product view controller
[rootViewController presentViewController:productController animated:YES completion:nil];
if ([self.delegate respondsToSelector:@selector(iRateDidPresentStoreKitModal)])
Expand Down Expand Up @@ -908,12 +915,7 @@ - (void)resizeAlertView:(UIAlertView *)alertView
}
else if ([label.text isEqualToString:alertView.message])
{

#if __IPHONE_OS_VERSION_MIN_REQUIRED >= __IPHONE_6_0
label.lineBreakMode = NSLineBreakByWordWrapping;
#else
label.lineBreakMode = UILineBreakModeWordWrap;
#endif
label.numberOfLines = 0;
label.alpha = 1.0f;
[label sizeToFit];
Expand Down

0 comments on commit 11514ee

Please sign in to comment.