Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic errors in usesUntilPrompt and eventsUntilPrompt? #287

Open
Permusoft opened this issue Apr 18, 2017 · 0 comments
Open

Logic errors in usesUntilPrompt and eventsUntilPrompt? #287

Permusoft opened this issue Apr 18, 2017 · 0 comments

Comments

@Permusoft
Copy link

Permusoft commented Apr 18, 2017 •
edited

https://github.com/nicklockwood/iRate/blob/master/iRate/iRate.m#L484

If either usesUntilPrompt or eventsUntilPrompt is zero then both values are effectively ignored. It's reasonable for developers to set one or the other to zero to indicate no interest in value.

Perhaps give eventsUntilPrompt its own else if, in keeping with the rest of shouldPromptForRating?
@Permusoft Permusoft changed the title Logic errors usesUntilPrompt and eventsUntilPrompt? Logic errors in usesUntilPrompt and eventsUntilPrompt? Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Permusoft