Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response.match(REGEX_COMMIT_DETAILS) is null in fetchGitData.js #30

Closed
paazmaya opened this issue Dec 17, 2013 · 1 comment
Closed

response.match(REGEX_COMMIT_DETAILS) is null in fetchGitData.js #30

paazmaya opened this issue Dec 17, 2013 · 1 comment

Comments

@paazmaya
Copy link
Contributor

https://travis-ci.org/paazmaya/naginata.fi/builds/15591863#L2253

This occurred ins 2.5.0 and in 2.6.0.
It seems that the latest successful report was made 5 days ago.

The output from the above test run:

/home/travis/build/paazmaya/naginata.fi/node_modules/coveralls/lib/fetchGitData.js:69

var items = response.match(REGEX_COMMIT_DETAILS).slice(1);

^

TypeError: Cannot call method 'slice' of null

at /home/travis/build/paazmaya/naginata.fi/node_modules/coveralls/lib/fetchGitData.js:69:54

at ChildProcess.exithandler (child_process.js:635:7)

at ChildProcess.EventEmitter.emit (events.js:98:17)

at maybeClose (child_process.js:735:16)

at Socket.<anonymous> (child_process.js:948:11)

at Socket.EventEmitter.emit (events.js:95:17)

at Pipe.close (net.js:466:12)
@paazmaya
Copy link
Contributor Author

I ran a bit of console output and turns out that the response is in my case:

tree b9d709b1545d546e1684fc4e0cd44ca187922bf9
parent 06bd19496d5506d4dc55e405e64addb800fc78ee
author Juga Paazmaya <paazmaya@yahoo.com> 1387295930 +0200
committer Juga Paazmaya <paazmaya@yahoo.com> 1387295930 +0200
encoding ISO-8859-15

Coveralls 2.5.0 seems to be failing at Travis CI due to some slicing issue, thus trying with later release

Since the regular expression assumes that the committer line is followed by an empty line, it does not match anything, as there is encoding defined.

This is the regular expression used.

/\nauthor (.+?) <(.+?)>.+\ncommitter (.+?) <(.+?)>.+\n\n(.*)/m

Perhaps it should be adjusted to match anything after committer until two new lines...

@cainus cainus closed this as completed in 827171e Dec 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant