Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: new paginationClickable is not filtered from underlying Swiper div props #28

Closed
SleepWalker opened this issue Jun 17, 2019 · 0 comments

Comments

@SleepWalker
Copy link

After adding paginationClickable in #27 Swiper component prints warning about props:

Warning: React does not recognize the `paginationClickable` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `paginationclickable` instead. If you accidentally passed it from a parent component, remove it from the DOM element.

The new prop was not added to _getNormProps:

_getNormProps (props) {
return omit(
props,
events.concat([
'containerClassName',
'wrapperClassName',
'swiperOptions',
'navigation',
'prevButton',
'nextButton',
'pagination',
'scrollBar',
'onInitSwiper'
])
)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants