Skip to content

Commit

Permalink
updating package to address CRAN issues.
Browse files Browse the repository at this point in the history
  • Loading branch information
nickreich committed Dec 6, 2019
1 parent 37d0158 commit 74ee00b
Show file tree
Hide file tree
Showing 7 changed files with 26 additions and 14 deletions.
4 changes: 3 additions & 1 deletion ChangeLog
Expand Up @@ -16,4 +16,6 @@ v0.6 - added Azman/Lessler contributions: MCMC estimation functions, ability to


v06.3 - minor modifications to address NAMESPACE issues. v06.3 - minor modifications to address NAMESPACE issues.


v06.4 - merged hackout3 branch to support new distributions v06.4 - merged hackout3 branch to support new distributions

v06.5 - minor modifications to fix improper call to `class()` and other new NOTES.
4 changes: 2 additions & 2 deletions DESCRIPTION
@@ -1,6 +1,6 @@
Package: coarseDataTools Package: coarseDataTools
Version: 0.6-4 Version: 0.6-5
Date: 2019-06-04 Date: 2019-12-05
Title: Analysis of Coarsely Observed Data Title: Analysis of Coarsely Observed Data
Authors@R: c(person("Nicholas G.", "Reich", email = "nick@schoolph.umass.edu", role = c("aut", "cre")), Authors@R: c(person("Nicholas G.", "Reich", email = "nick@schoolph.umass.edu", role = c("aut", "cre")),
person("Justin", "Lessler", email = "jlessler@jhsph.edu", role = "aut"), person("Justin", "Lessler", email = "jlessler@jhsph.edu", role = "aut"),
Expand Down
1 change: 1 addition & 0 deletions NAMESPACE
Expand Up @@ -17,6 +17,7 @@ importFrom(MCMCpack,MCMCmetrop1R)
importFrom(grDevices,rgb) importFrom(grDevices,rgb)
importFrom(graphics,lines) importFrom(graphics,lines)
importFrom(graphics,plot) importFrom(graphics,plot)
importFrom(methods,is)
importFrom(methods,new) importFrom(methods,new)
importFrom(stats,coef) importFrom(stats,coef)
importFrom(stats,dgamma) importFrom(stats,dgamma)
Expand Down
2 changes: 1 addition & 1 deletion R/coarseDataTools-package.R
Expand Up @@ -80,6 +80,6 @@ NULL
##' @examples ##' @examples
##' data(nycH1N1) ##' data(nycH1N1)
##' head(nycH1N1) ##' head(nycH1N1)
##' dic.fit(nycH1N1) ##' \dontrun{dic.fit(nycH1N1)}
##' @keywords datasets ##' @keywords datasets
NULL NULL
3 changes: 2 additions & 1 deletion R/dic.fit.R
Expand Up @@ -41,6 +41,7 @@
##' @param n.boots number of bootstrap resamples (0 means that asymptotic results are desired) ##' @param n.boots number of bootstrap resamples (0 means that asymptotic results are desired)
##' @param ... additional options passed to optim ##' @param ... additional options passed to optim
##' @return a cd.fit S4 object. ##' @return a cd.fit S4 object.
##' @importFrom methods is
##' @seealso \code{\link{cd.fit}}, \code{\link{dic.fit.mcmc}} ##' @seealso \code{\link{cd.fit}}, \code{\link{dic.fit.mcmc}}
##' @export ##' @export
##' @examples ##' @examples
Expand Down Expand Up @@ -77,7 +78,7 @@ dic.fit <- function(dat,


## make sure dat is a matrix ## make sure dat is a matrix
dat <- as.matrix(dat[,c("EL", "ER", "SL", "SR", "type")]) dat <- as.matrix(dat[,c("EL", "ER", "SL", "SR", "type")])
if(class(dat)=="data.frame") stop("dat should be a matrix.") if(is(dat,"data.frame")) stop("dat should be a matrix.")


## find starting values for DIC analysis using profile likelihoods ## find starting values for DIC analysis using profile likelihoods
start.par1 <- optimize(f=pl.par1, interval=par1.int, start.par1 <- optimize(f=pl.par1, interval=par1.int,
Expand Down
24 changes: 16 additions & 8 deletions cran-comments.md
@@ -1,17 +1,25 @@
## requested fixes ## updates in this edition
- fixed NOTES about canonical URLs
- as requested: fixed improper call to `class(dat) == "data.frame"` with a call to `is(dat, "data.frame")`




## R CMD check results ## R CMD check results
There were no ERRORs or WARNINGs. > On windows-x86_64-devel (r-devel)
checking sizes of PDF files under 'inst/doc' ... NOTE
Unable to find GhostScript executable to run checks on size reduction


Notes arose from running checks on Rhub: Unable to figure out whether this is an issue with the server running the checks or something in the package itself that I can/should be changing.


``` > On fedora-clang-devel (r-devel)
checking CRAN incoming feasibility ...NB: need Internet access to use CRAN incoming checks
NOTE
Maintainer: ‘Nicholas G. Reich <nick@schoolph.umass.edu>

Possibly mis-spelled words in DESCRIPTION: Possibly mis-spelled words in DESCRIPTION:
al (20:34, 21:14, 22:16)
Lessler (22:5) Lessler (22:5)
al (20:34, 21:14, 22:16)
et (20:31, 21:11, 22:13) et (20:31, 21:11, 22:13)
```


These are expected, as they are abbreviations and last names from citations requested by CRAN maintainers.
These are expected, as they are abbreviations and last names from citations requested by CRAN maintainers.

2 changes: 1 addition & 1 deletion man/nycH1N1.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 74ee00b

Please sign in to comment.