New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idiomatic #23
Merged
Merged
Idiomatic #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test passes
- Replace `if let Some(encoder) = ...` with `ok_or` for more idiomatic error handling. - Move error check and return inside the loop for improved flow control.
The previous code would panic in debug and silently wraparound in release. This change makes it explicitily wraparound in both production and debug. Other methods are available to make it explicit usize.overflowing_add or usize.checked_add it isnt clear how it should be handled here though
something like this would be idiomatic,
|
Ousret/charset_normalizer@8a13cab #329 in original repo
(self.current_ascii_only, character.is_ascii(), Result of &= operation) (True True True) (True False False) (False True False) (False False False)
Every single item is set to default of its type so we can just derive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a85c5fe is worth looking at.
This would only be a problem when the file size is around
usize::MAX
which is around 2^64 bytes.