Skip to content

Commit

Permalink
feat(lib): support for angular v9 (#128)
Browse files Browse the repository at this point in the history
BREAKING CHANGE:
Rename properties to follow angular style guide

Before:

[ngx-scroll-to]
[ngx-scroll-to-event]
[ngx-scroll-to-duration]
[ngx-scroll-to-easing]
[ngx-scroll-to-offset]
[ngx-scroll-to-offset-map]

After:

[ngxScrollTo]
[ngxScrollToEvent]
[ngxScrollToDuration]
[ngxScrollToEasing]
[ngxScrollToOffset]
[ngxScrollToOffsetMap]

* **core:** Fix lint
  • Loading branch information
Jonnyprof committed Apr 22, 2020
1 parent 23d4091 commit 4d4425b
Show file tree
Hide file tree
Showing 82 changed files with 11,697 additions and 17,291 deletions.
24 changes: 12 additions & 12 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ references:
docker:
- *image_node_browsers

restore_npm_cache: &restore_npm_cache
restore_yarn_cache: &restore_yarn_cache
restore_cache:
key: dependency-cache-{{ checksum "package.json" }}

restore_npm_cache_peer: &restore_npm_cache_peer
restore_yarn_cache_peer: &restore_yarn_cache_peer
restore_cache:
key: dependency-cache-peer-{{ checksum "package.json" }}

Expand All @@ -51,11 +51,11 @@ jobs:
<<: *job_defaults
steps:
- checkout
- *restore_npm_cache
- *restore_npm_cache_peer
- *restore_yarn_cache
- *restore_yarn_cache_peer
- run:
name: Install NodeJS Dependencies via NPM
command: npm install
name: Install NodeJS Dependencies via YARN
command: yarn install
- save_cache:
key: dependency-cache-{{ checksum "package.json" }}
paths:
Expand All @@ -64,20 +64,20 @@ jobs:
<<: *job_defaults_browsers
steps:
- checkout
- *restore_npm_cache
- *restore_npm_cache_peer
- *restore_yarn_cache
- *restore_yarn_cache_peer
- run:
name: Test Spec
command: npm run lib:test
command: yarn test
lint:
<<: *job_defaults
steps:
- checkout
- *restore_npm_cache
- *restore_npm_cache_peer
- *restore_yarn_cache
- *restore_yarn_cache_peer
- run:
name: Lint TypeScript
command: npm run ng:lint
command: yarn lint

# Workflows
workflows:
Expand Down
5 changes: 4 additions & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Editor configuration, see http://editorconfig.org
# Editor configuration, see https://editorconfig.org
root = true

[*]
Expand All @@ -8,6 +8,9 @@ indent_size = 2
insert_final_newline = true
trim_trailing_whitespace = true

[*.ts]
quote_type = single

[*.md]
max_line_length = off
trim_trailing_whitespace = false
9 changes: 9 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,16 @@
/dist
/tmp
/out-tsc
# Only exists if Bazel was run
/bazel-out

# dependencies
/node_modules

# profiling files
chrome-profiler-events*.json
speed-measure-plugin*.json

# IDEs and editors
/.idea
.project
Expand All @@ -23,14 +29,17 @@
!.vscode/tasks.json
!.vscode/launch.json
!.vscode/extensions.json
.history/*

# misc
/.sass-cache
/connect.lock
/coverage
/libpeerconnection.log
npm-debug.log
yarn-error.log
testem.log
/typings

# System Files
.DS_Store
Expand Down
50 changes: 50 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,53 @@
<a name="9.0.0"></a>
# [9.0.0](https://github.com/nicky-lenaers/ngx-scroll-to/compare/3.0.1...9.0.0) (2020-04-22)


### Bug Fixes

* scroll to element with relative positioned parent ([#124](https://github.com/nicky-lenaers/ngx-scroll-to/issues/124)) ([4d2c775](https://github.com/nicky-lenaers/ngx-scroll-to/commit/4d2c775))


### Features

* **lib:** support for angular v9 ([4b50770](https://github.com/nicky-lenaers/ngx-scroll-to/commit/4b50770))


### BREAKING CHANGES

* **lib:** Rename properties to follow angular style guide

Before:

[ngx-scroll-to]
[ngx-scroll-to-event]
[ngx-scroll-to-duration]
[ngx-scroll-to-easing]
[ngx-scroll-to-offset]
[ngx-scroll-to-offset-map]

After:

[ngxScrollTo]
[ngxScrollToEvent]
[ngxScrollToDuration]
[ngxScrollToEasing]
[ngxScrollToOffset]
[ngxScrollToOffsetMap]

* **core:** Fix lint



<a name="3.0.1"></a>
## [3.0.1](https://github.com/nicky-lenaers/ngx-scroll-to/compare/3.0.0...3.0.1) (2019-08-13)


### Bug Fixes

* incorrect package version ([abd2e97](https://github.com/nicky-lenaers/ngx-scroll-to/commit/abd2e97))



<a name="3.0.0"></a>
# [3.0.0](https://github.com/nicky-lenaers/ngx-scroll-to/compare/2.0.0...3.0.0) (2019-08-13)

Expand Down

0 comments on commit 4d4425b

Please sign in to comment.