Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rxjs import #115

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Fix rxjs import #115

merged 1 commit into from
Mar 26, 2019

Conversation

squelix
Copy link
Contributor

@squelix squelix commented Feb 5, 2019

Fix #110

Replace all rjx/index imports to prevent rxjs to be imported entirely.

@squelix squelix changed the title fix(lib): replace "... from 'rjx/index'" import by "...from 'rxjs'" Fix [#110](https://github.com/nicky-lenaers/ngx-scroll-to/issues/110) Feb 5, 2019
@squelix squelix changed the title Fix [#110](https://github.com/nicky-lenaers/ngx-scroll-to/issues/110) Fix rxjs import Feb 5, 2019
@squelix
Copy link
Contributor Author

squelix commented Feb 26, 2019

up ?

@robbertvancaem
Copy link
Collaborator

@squelix Seems to be fine. @nicky-lenaers Any idea why the circleci build is stuck?

@nicky-lenaers nicky-lenaers merged commit 452a986 into nicky-lenaers:master Mar 26, 2019
@squelix
Copy link
Contributor Author

squelix commented Mar 31, 2019

New release ?

@robbertvancaem
Copy link
Collaborator

@squelix After merging your PR we ran into a configuration issue when trying to prepare a new release. We'll try to publish a new release asap @nicky-lenaers .

@beyondsanity
Copy link

Hello, is there any news on the release?

@squelix
Copy link
Contributor Author

squelix commented Jul 8, 2019

Hello ??? @nicky-lenaers ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scroll-to.service.ts imports from 'rxjs/index'
4 participants