-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compatible with Angular 8 #121
Comments
This appears to work fine in Angular 8. Though, the following warnings are present: warning " > @nicky-lenaers/ngx-scroll-to@2.0.0" has incorrect peer dependency "@angular/common@^7.1.0".
warning " > @nicky-lenaers/ngx-scroll-to@2.0.0" has incorrect peer dependency "@angular/core@^7.1.0".
WARNING in Entry point '@nicky-lenaers/ngx-scroll-to' contains deep imports into 'rxjs/index'. This is probably not a problem, but may cause the compilation of entry points to be out of order. Update: Does not work when Ivy is in enabled with Angular 8 |
Just upgraded to angular 8, would be nice to have this warning removed. :-) |
Any updates on this? Seems to be working in Angular 8 but would like to have that warning removed too :) |
Bump |
Some news here @nicky-lenaers ? |
See #123 |
thanks @nicky-lenaers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please add support of Angular 8
The text was updated successfully, but these errors were encountered: