Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with Angular 8 #121

Closed
Zwergenpunk opened this issue May 29, 2019 · 7 comments
Closed

Make compatible with Angular 8 #121

Zwergenpunk opened this issue May 29, 2019 · 7 comments

Comments

@Zwergenpunk
Copy link

Zwergenpunk commented May 29, 2019

Please add support of Angular 8

@danielmoncada
Copy link

danielmoncada commented May 31, 2019

This appears to work fine in Angular 8. Though, the following warnings are present:

warning " > @nicky-lenaers/ngx-scroll-to@2.0.0" has incorrect peer dependency "@angular/common@^7.1.0".
warning " > @nicky-lenaers/ngx-scroll-to@2.0.0" has incorrect peer dependency "@angular/core@^7.1.0".

WARNING in Entry point '@nicky-lenaers/ngx-scroll-to' contains deep imports into 'rxjs/index'. This is probably not a problem, but may cause the compilation of entry points to be out of order.

Update: Does not work when Ivy is in enabled with Angular 8

@HarelM
Copy link

HarelM commented Jun 26, 2019

Just upgraded to angular 8, would be nice to have this warning removed. :-)

@iantrudell
Copy link

Any updates on this? Seems to be working in Angular 8 but would like to have that warning removed too :)

@pburkindine
Copy link

Bump

@rafa-suagu
Copy link
Collaborator

Some news here @nicky-lenaers ?

@nicky-lenaers
Copy link
Owner

See #123

@rafa-suagu
Copy link
Collaborator

thanks @nicky-lenaers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants