Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignIn component added by kirimase init even when nextauth wasn't selected #12

Closed
BeauSLM opened this issue Sep 7, 2023 · 2 comments
Closed

Comments

@BeauSLM
Copy link

BeauSLM commented Sep 7, 2023

Repro:

  • I'm using pnpm
  • from fresh create-next-app starter with the default options
  • ran kirimase init and selected shadcn, trpc, and drizzle but NOT nextauth
  • src/components/auth/SignIn.tsx file created, looks like this
"use client";
import { useSession, signIn, signOut } from "next-auth/react";
import { Button } from "../ui/button";

export default function SignIn() {
  const { data: session, status } = useSession();

  if (status === "loading") return <div>Loading...</div>;

  if (session) {
    return (
      <>
        Signed in as {session.user?.email} <br />
        <Button variant={"destructive"} onClick={() => signOut()}>Sign out</Button>
      </>
    );
  }
  return (
    <>
      Not signed in <br />
      <Button onClick={() => signIn()}>Sign in</Button>
    </>
  );
}
@BeauSLM
Copy link
Author

BeauSLM commented Sep 7, 2023

another odd quirk, when I then run kirimase add and select nextauth, it removes the Button component from SignIn.tsx and uses a normal button. Diff below:

diff --git a/src/components/auth/SignIn.tsx b/src/components/auth/SignIn.tsx
index 20dcdef..22fdc18 100644
--- a/src/components/auth/SignIn.tsx
+++ b/src/components/auth/SignIn.tsx
@@ -1,6 +1,5 @@
 "use client";
 import { useSession, signIn, signOut } from "next-auth/react";
-import { Button } from "../ui/button";
 
 export default function SignIn() {
   const { data: session, status } = useSession();
@@ -11,14 +10,14 @@ export default function SignIn() {
     return (
       <>
         Signed in as {session.user?.email} <br />
-        <Button variant={"destructive"} onClick={() => signOut()}>Sign out</Button>
+        <button onClick={() => signOut()}>Sign out</button>
       </>
     );
   }
   return (
     <>
       Not signed in <br />
-      <Button onClick={() => signIn()}>Sign in</Button>
+      <button onClick={() => signIn()}>Sign in</button>
     </>
   );
-}
\ No newline at end of file
+}

@nicoalbanese
Copy link
Owner

Hey - thanks for flagging! Have fixed and will be fixed with the next update to npm (within next day or so). Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants