Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Improve handling of false value in config #219

Closed
nicoduj opened this issue Jan 25, 2020 · 1 comment
Closed

[FEATURE] Improve handling of false value in config #219

nicoduj opened this issue Jan 25, 2020 · 1 comment
Assignees
@nicoduj
Labels
enhancement New feature or request
Projects
Harmony Hub Plugin for Homebridge
Milestone
1.2.4

Comments

@nicoduj
Copy link
Owner

nicoduj commented Jan 25, 2020

Boolean options set to "false" and not false in config are interpreted as true.
@nicoduj nicoduj added the enhancement New feature or request label Jan 25, 2020
@nicoduj nicoduj added this to the 1.3.0 milestone Jan 25, 2020
@nicoduj nicoduj self-assigned this Jan 25, 2020
@nicoduj nicoduj added this to To do in Harmony Hub Plugin for Homebridge via automation Jan 25, 2020
@nicoduj
Copy link
Owner Author

nicoduj commented Jan 25, 2020

be careful with showTurnOffActivity which is an enum

@nicoduj nicoduj changed the title [FEATURE] Improove handling of false value in config [FEATURE] Improve handling of false value in config Jan 25, 2020
@nicoduj nicoduj modified the milestones: 1.3.0, 1.2.4 Jan 25, 2020
@nicoduj nicoduj mentioned this issue Jan 25, 2020
Closed
@nicoduj nicoduj closed this as completed Jan 25, 2020
Harmony Hub Plugin for Homebridge automation moved this from To do to Done Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicoduj nicoduj

Labels
enhancement New feature or request
Projects
Harmony Hub Plugin for Homebridge
  
Done
Milestone
1.2.4
Development

No branches or pull requests
1 participant
@nicoduj