Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abracadabra replaces system key binding #817

Closed
stevebeauge opened this issue Feb 15, 2023 · 3 comments
Closed

Abracadabra replaces system key binding #817

stevebeauge opened this issue Feb 15, 2023 · 3 comments
Labels
🐛 Bug Refactoring breaks existing behavior

Comments

@stevebeauge
Copy link

stevebeauge commented Feb 15, 2023

Describe the bug

This extension shouldn't overrides the standard CTRL + H key-binding.

How to reproduce

Press CTRL + H in a editor. It trigger the @command:abracadabra.toggleHighlight

Expected behavior

Standard VS code's replace UI should open.

Screenshots

image.

I have no custom keybinding defined. This is the OOB VS Code + abracadabra setup

Additional information

Working on Windows, where CTRL + H is the de-facto key shortcut for replacing text in nearly all text editors.

@stevebeauge stevebeauge added the 🐛 Bug Refactoring breaks existing behavior label Feb 15, 2023
@nicoespeon
Copy link
Owner

Oh crap, I forgot to double-check this was an OK shortcut on Windows 🤦

Yeah, that sucks. I'm changing that and shipping an updated version. New shortcuts will be:

Feature Keybinding On Mac
Toggle Highlight Ctrl + Alt + H ⌃ H
Refresh Highlights Shift + Alt + H ⌃ ⌥ H
Remove All Highlights Ctrl + Shift + Alt + H ⇧ ⌃ H

@all-contributors please add stevebeauge for bugs 🙏

@allcontributors
Copy link
Contributor

@nicoespeon

I've put up a pull request to add @stevebeauge! 🎉

@stevebeauge
Copy link
Author

That was quick!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Refactoring breaks existing behavior
Projects
None yet
Development

No branches or pull requests

2 participants