Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support log level off #11

Merged
merged 1 commit into from
Jul 9, 2019
Merged

feat: support log level off #11

merged 1 commit into from
Jul 9, 2019

Conversation

Aqours
Copy link
Contributor

@Aqours Aqours commented Jul 9, 2019

We can ignore EEXIST 'errors' which does not cause terminal exist, that look like real errors on CI/Linux/macOS platform.

@nicojs nicojs merged commit f0cdec3 into nicojs:master Jul 9, 2019
@nicojs
Copy link
Owner

nicojs commented Jul 9, 2019

Maybe we could if we catch and handle the error correctly?

@nicojs
Copy link
Owner

nicojs commented Jul 9, 2019

I think this is the culprit:

console.error('Error Linking packages', err);
process.exit(1);

@nicojs
Copy link
Owner

nicojs commented Jul 9, 2019

@Aqours
Copy link
Contributor Author

Aqours commented Jul 9, 2019

.catch(err => this.log.error(`Could not link bin ${bin} for child ${childPackage}.`, err))))));

I think we should override existed bin file or catch EEXIST error and give a warning to user, because these errors does not affect child packages bin file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants