feat(dispose): dispose child injectors #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way
dispose
works. Instead of anInjector
disposing it's own provided dependencies and then calldispose
on the parent, it will dispose its childInjector
's (that were created usingprovideXXX
) and then it's own dependencies. The parentInjector
will no longer be disposed of.This allows you to dispose from the rootInjector down:
Because now an
Injector
has to keep track of its child injectors, therootInjector
would no longer be stateless. That's why it is removed altogether. Developers are expected to create their own (root) injector usingcreateInjector()
.BREAKING CHANGE:
rootInjector
is removed in favor ofcreateInjector
.This:
Becomes:
Injector's created from
createInjector
are no longer stateless. Theykeep track of their child injectors.
BREAKING CHANGE:
dispose
no longer disposes parent injector, disposesthe child injectors instead. See readme for more details.
Fixes #24