Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore model from config and weights for model training, via CLI option #7

Closed
nicolafan opened this issue Mar 13, 2023 · 2 comments · Fixed by #9
Closed

Restore model from config and weights for model training, via CLI option #7

nicolafan opened this issue Mar 13, 2023 · 2 comments · Fixed by #9
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nicolafan
Copy link
Owner

Add a CLI option to model training that provides the possibility to continue training an existing model.

If the option is specified, with the model filename, we should ignore all the parameters that refer to the model architecture or raise an error if they are specified.

@nicolafan nicolafan added good first issue Good for newcomers enhancement New feature or request labels Mar 13, 2023
@IsraelAbebe
Copy link
Contributor

@nicolafan
want to work on this issue. Is the below command what you want to add as as option?

python -m src.models.train_model --model_path 'models/weights/train_20230314-012026.h5' --config_path models/config/train_20230314-012026.json

@nicolafan
Copy link
Owner Author

Hi @IsraelAbebe thank you for wanting to contribute!

Currently, according to the model evaluation which already restores a saved model, the command as I thought it would be:

python -m src.models.train_model --model_filename 'train_20230314'

And it will restore the weights and model accordingly.

I will assign this issue to you. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants