Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The keyword "directive " is lost #10

Closed
lipigirl opened this issue Apr 25, 2018 · 6 comments
Closed

The keyword "directive " is lost #10

lipigirl opened this issue Apr 25, 2018 · 6 comments

Comments

@lipigirl
Copy link

lipigirl commented Apr 25, 2018

If the keyword directive is used in the schema ( see Schema directives ), it is lost after using the function transpileSchema.

@nicolasdao
Copy link
Owner

Thanks for pointing that out @lipigirl. Gonna fix that asap.

@nicolasdao
Copy link
Owner

Hi @lipigirl,

This should be fixed with the latest release (i.e., 0.16.0).

Let me know if that works on your side.

Thanks a lot for pointing that out. This really helps to make this project better.

Cheers,

Nic

@lipigirl
Copy link
Author

lipigirl commented May 2, 2018

@nicolasdao

Thanks a lot,the keyword directive worked,

But when the generic <T> is used together, there's another problem,

For example,

 var schema =
directive @rest
 (
   type: String
   url: String
 ) on FIELD_DEFINITION | ENUM_VALUE
 
 type Manager<T> {
    name: String
 }
 
 type PageList<T> {
    results: [T]
 }
 
 type Query {
   querySome: PageList<Manager> @rest(type: "GET",url:"/198.168.0.1")
 }
 var schema_output =
directive @rest
 (
   type: String
   url: String
 ) on FIELD_DEFINITION | ENUM_VALUE
 
 type Manager<T> {
    name: String
 }
 
 type PageList<T> {
    results: [T]
 }
 
 type Query {
   querySome: PageList<Manager>//lost @rest(type: "GET",url:"/198.168.0.1")
 }

@nicolasdao nicolasdao reopened this May 2, 2018
@nicolasdao
Copy link
Owner

Hi @lipigirl ,

Damn, I'm sorry that this issue is not fully resolved. Thank you so much reporting that. I'll fix that asap.

@nicolasdao
Copy link
Owner

Hi @lipigirl ,

This issue should be fixed with the latest version (0.16.1). Can you give it a shot and let me know if that's working on your side?

@lipigirl
Copy link
Author

lipigirl commented May 8, 2018

Hi @nicolasdao
This issue is perfect fixed,Thanks a lot~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants