Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParsedRow -- depends on pandas, while it might be switched to dict type instead [AREnets backlog] #427

Closed
4 tasks
nicolay-r opened this issue Dec 22, 2022 · 2 comments
Closed
4 tasks

ParsedRow -- depends on pandas, while it might be switched to dict type instead [AREnets backlog] #427

nicolay-r opened this issue Dec 22, 2022 · 2 comments
Labels
critical enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Dec 22, 2022 •
edited
Loading

See side project refactoring:

  • setup assert for row type to dict
  • update the related rows providers, __iter__ suppose to return dict everywhere
  • simplify reading process by make it less reliable from pandas
  • check unit tests as well

See:
d5e438cd0e44cb2a8ef8cb60f12c6cd53a62590d
@nicolay-r nicolay-r added enhancement New feature or request critical labels Dec 22, 2022
@nicolay-r
Copy link
Owner Author

Not relevant, since it was moved to AREnets

@nicolay-r nicolay-r added the invalid This doesn't seem right label Dec 22, 2022
@nicolay-r
Copy link
Owner Author

AREkit/arekit/contrib/networks/input/rows_parser.py

Lines 48 to 49 in 5a60ca3

def __init__(self, row):
assert(isinstance(row, pd.Series))

@nicolay-r nicolay-r reopened this Dec 22, 2022
@nicolay-r nicolay-r removed the invalid This doesn't seem right label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
critical enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r