Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all minors of @babel/core #2

Closed
SimenB opened this issue Apr 6, 2020 · 5 comments
Closed

Support all minors of @babel/core #2

SimenB opened this issue Apr 6, 2020 · 5 comments

Comments

@SimenB
Copy link
Collaborator

SimenB commented Apr 6, 2020

Right now the minimum is ^7.8.0, it'd be awesome to support all the way down to ^7.0.0. You get the version passed to the preset function so we can still avoid adding too many plugins, right? I'm not sure how much more of a maintenance burden that'd add, but I'm hoping it's feasible 😀

If we do this, I can add this preset to Jest without waiting for a new major (our current peer dependency is ^7.0.0)

@nicolo-ribaudo
Copy link
Owner

Adding too many syntax plugins shouldn't hurt, because most of the time is spent while transforming the AST rather than when initializing plugins (syntax plugins only run during initialization).

@nicolo-ribaudo
Copy link
Owner

nicolo-ribaudo commented Apr 6, 2020

Added in 155d2cc. I tested it locally with different node versions and it seems to work, but I want to wait for GH actions to be up again before releasing.

@SimenB
Copy link
Collaborator Author

SimenB commented Apr 6, 2020

Wonderful, thanks!

@SimenB
Copy link
Collaborator Author

SimenB commented Apr 6, 2020

Ping me when released? 🙂

@nicolo-ribaudo
Copy link
Owner

@SimenB Published as 0.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants