Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass PM #1860

Closed
woollarding opened this issue Jan 30, 2022 · 2 comments
Closed

Mass PM #1860

woollarding opened this issue Jan 30, 2022 · 2 comments
Milestone

Comments

@woollarding
Copy link

Describe the solution you'd like

it was just pointed out to me that QT has the ability to send a mass private message to all buddy list users... if nicotine does this i have not figured out how yet.. would also be helpful to be able to message all user in my upload queue

@mathiascode
Copy link
Member

mathiascode commented Jan 31, 2022

The protocol message is there, it just needs to be implemented in the GUI.

class MessageUsers(ServerMessage):
""" Server code: 149 """
""" Sends a broadcast private message to the given list of users. """
def __init__(self, users=None, msg=None):
self.users = users
self.msg = msg
def make_network_message(self):
msg = bytearray()
msg.extend(self.pack_object(len(self.users)))
for user in self.users:
msg.extend(self.pack_object(user))
msg.extend(self.pack_object(self.msg))

@slook
Copy link
Member

slook commented Jan 31, 2022

I had also spotted this in the protocol documentation a few times and wondered a similar thing:
https://github.com/nicotine-plus/nicotine-plus/blob/master/doc/SLSKPROTOCOL.md#server-code-149

It would be my guess that the function has not yet been implemented because of the risk of it being misused by spammers, however as it turns out over time this doesn't seem to be a large issue on the network.

be helpful to be able to message all user in my upload queue

For this use case I can see the benefit of having this function, it could be a useful idea. The transfers module stores a list of active and queued users which could be accessible from a plugin perhaps. It wouldn't surprise me if someone in the community has developed such a thing, but I am not aware if this is so.

A possible built-in implementation would be in the multi-select 'Users' context menu, perhaps a menu-item with a label such as "Send Broadcast Message..." (alongside the username sub-menu items) could trigger a text entry dialog.

Naturally this would lead to the requirement for multi-select in the Buddies list, so there is some additional complexity there to handle the context menus and whatnot. It's probably not a good idea to make this function available from Search Files nor public Chat Rooms, restricting it to Buddies and users in the transfers lists would seem reasonable.

@mathiascode mathiascode added this to the 3.3.0 milestone Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants