Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upnp Port does not close upon exit of nicotine+ #2393

Closed
Sakooooo opened this issue Feb 15, 2023 · 3 comments
Closed

Upnp Port does not close upon exit of nicotine+ #2393

Sakooooo opened this issue Feb 15, 2023 · 3 comments
Labels
Milestone

Comments

@Sakooooo
Copy link

Nicotine+ version:
Operating System/Distribution:
Windows 10 21H2

Describe the bug

When exiting Nicotine+ and then going into my router's upnp page it says that nicotine+ is still opening the port

Expected behavior

Upnp should say the port is closed and should open again on next launch

Steps to reproduce the bug

  1. Open Nicotine+ with UPNP port forwarding
  2. Open router UPNP homepage
  3. Close Nicotine+
  4. Port should say it is still open

Small Workaround until it is fixed

  1. Turn off Upnp
  2. Turn it on again

This also happens with the original SoulSeek Client

@Sakooooo Sakooooo added the bug label Feb 15, 2023
@mathiascode
Copy link
Member

The port mapping expires after 24 hours, but I suppose we could also remove it when closing Nicotine+.

@Sakooooo
Copy link
Author

I think it would just be better to just add it as an option in that case

@Sakooooo
Copy link
Author

woohoo awesome :D thanks man

@mathiascode mathiascode added this to the 3.3.0 milestone Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants