Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show total folder size on search tab #2697

Closed
oTalDoNexus opened this issue Oct 20, 2023 · 3 comments
Closed

Show total folder size on search tab #2697

oTalDoNexus opened this issue Oct 20, 2023 · 3 comments
Milestone

Comments

@oTalDoNexus
Copy link

First of all, thanks for the amazing project..

So my feature request is that we could be able to show the total folder size, since we can just see their size individually, i was searching for that on official SoulSeek but couldn't find it and by search i just found Nicotine and i like it a lot! Thanks in advance

@slook
Copy link
Member

slook commented Oct 20, 2023

It would only be possible to display the size of whichever files that are displayed from each folder, not the total of all the other files that might exist in each displayed folder (because that would involve making a FolderContentsRequest to every individual peer after getting the results, which is not allowed on the protocol).

@mathiascode
Copy link
Member

In Nicotine+ 3.3.0, you will be able to select a folder row in search results -> File Properties, and the total size of the visible files will appear in the title of the file properties dialog.

For search results where the whole folder isn't displayed, when #1659 is implemented in the future, we could show the total size of the folder there.

@mathiascode
Copy link
Member

Closing in favor of #1659

@mathiascode mathiascode closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
@mathiascode mathiascode added this to the 3.3.0 milestone Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants