New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make banning user stop them from viewing profile #2710
Comments
If I might add a nuance to this. I think banning PMs should be a separate action. Banning, imho, should be the last resort for a "bad" user, not the first (Sadly, I've seen it used as the first option without even a message as to why). I believe we should (somehow) enforce communication between users BEFORE a ban can occur. There could be a miscommunication, or a share improperly read/detected, etc. If you then, automatically cut off all communication because of a ban, then the issue can NEVER be rectified. That, imho, would be a disservice to all, and I also feel it could be abused. |
well banning you can still send and receive messages to them, ignoring stops you from seeing them. there's no real way to "block" communication, only hide. but yeah maybe an extra option would be nice. I think even like an option for making PM's buddy only would be cool too |
Is the main concern that banned users can read your personal description? We currently hide the picture from banned users, and add a ban message above the description, but we could also hide the description if that helps. |
Yeah, or an option to hide specific elements (description, picture, interests? I'm not sure about the limitations of the protocol, but if there is an ability to "refuse" the connection entirely and appear as offline. If it's possible to improve the blocking/restriction functionality of the client I think that would be awesome. (maybe also an option to disable the ban message too lol) |
The only things that can be hidden are the description, picture and the upload slot-related stats (set them to some other value). Everything else is provided by the Soulseek server. |
Would it be possible to add a n option to make it not show any ban message in the description? |
Not sure what difference it makes, since a user would presumably be banned while downloading something, and see the "Banned" status in the download list. |
Although I suppose we could go the same route as SoulseekQt, and change the "Banned" status to "File not shared": https://www.slsknet.org/news/node/156 If you set a custom ban reason, it would show up in the description, otherwise the description would be empty. |
I think that if a user is banned, the user should KNOW they are banned - and why. People make mistakes - such as Leech Detector not showing any files because they accidentally changed drive letters, moved stuff and didn't refresh, etc. Messaging them with a notification allows them to respond and correct any "issue". I would not want to see "Ban Abuse" - for that matter, I REALLY don't like the "File Not Shared" option - that IS abused FAR too often. Either something should be available & shared, or not available at all - and therefore not show up in searches. Allowing the "File Not Shared" permits abuse by users with unreasonable "demands". |
I think under normal circumstances, yeah, but for someone like me that don't use stuff like auto ban, I'd rather have the option to just "block" the person; it should ultimately be up to the person hosting the files if they would like to disclose the reason why they banned a user. i think a simple solution would just be an extra option in the banned message tab for the profile description. |
Please be specific, what kind of option (checkbox, radio buttons, dropdown), what string of text should the label(s) say, where location to place, propose what the internal config name reference, etc. |
How about a compromise? Keep the "Banned" transfer status, but show an empty profile description unless a custom ban reason is set in Preferences -> Banned Users? It's too late to add new options to 3.3.0 anyway, we've entered string freeze so translators can finish their work. At some point in the future we'll move away from the global ban reason/message to per-user messages. |
yeah that sounds cool 😊 |
Describe the solution you'd like
click ban user --> Dont reply to PM_USER_INFO_REQUEST
Additional context
maybe block file search too if it isn't already
The text was updated successfully, but these errors were encountered: