New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement server code 160 #2854
Comments
I did notice the message appearing the other day, but SoulseekQt doesn't use it yet to my knowledge. I'll wait until there's an official update.
I don't think this is true, because there's already a server-side blacklist for searches. It would make more sense for these strings to be checked when rescanning shares, but again, I'll wait until the message is used in the official client. |
It is already used in the latest build (2024.2.1), most stuff is already filtered on the server side however it seems to be less strict for user search. The message is there too, easiest way to reproduce is share a file with the banned name in the filename (eg.: "banned name - something") then perform a user search for "something". Under Diagnostics > Searches you will see a message : "Discarding result due to filter banned name" (something along those lines) |
I see, so it's a stricter filter to prevent banned files from being sent in search responses, no matter what search query was used. I'll check how it can be implemented in Nicotine+ without sacrificing performance too much. |
For posterity, these are the exact requirements provided by Soulseek's administrators:
|
Describe the solution you'd like
Server code 160 contains a list of search terms that should be blocked by the client, and seems to have been added recently (it is sent post-logon). When being queried, search results matching these strings should be filtered out.
Additional context
Discussion on Reddit here: https://www.reddit.com/r/Soulseek/comments/19czgxk/is_this_legit/
The text was updated successfully, but these errors were encountered: