Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement server code 160 #2854

Closed
JurgenR opened this issue Feb 3, 2024 · 4 comments · Fixed by #2855
Closed

Implement server code 160 #2854

JurgenR opened this issue Feb 3, 2024 · 4 comments · Fixed by #2855
Milestone

Comments

@JurgenR
Copy link

JurgenR commented Feb 3, 2024

Describe the solution you'd like

Server code 160 contains a list of search terms that should be blocked by the client, and seems to have been added recently (it is sent post-logon). When being queried, search results matching these strings should be filtered out.

Additional context

Discussion on Reddit here: https://www.reddit.com/r/Soulseek/comments/19czgxk/is_this_legit/

@mathiascode
Copy link
Member

mathiascode commented Feb 3, 2024

I did notice the message appearing the other day, but SoulseekQt doesn't use it yet to my knowledge. I'll wait until there's an official update.

When being queried, search results matching these strings should be filtered out.

I don't think this is true, because there's already a server-side blacklist for searches. It would make more sense for these strings to be checked when rescanning shares, but again, I'll wait until the message is used in the official client.

@JurgenR
Copy link
Author

JurgenR commented Feb 3, 2024

It is already used in the latest build (2024.2.1), most stuff is already filtered on the server side however it seems to be less strict for user search. The message is there too, easiest way to reproduce is share a file with the banned name in the filename (eg.: "banned name - something") then perform a user search for "something". Under Diagnostics > Searches you will see a message : "Discarding result due to filter banned name" (something along those lines)

@mathiascode
Copy link
Member

I see, so it's a stricter filter to prevent banned files from being sent in search responses, no matter what search query was used. I'll check how it can be implemented in Nicotine+ without sacrificing performance too much.

@mathiascode
Copy link
Member

For posterity, these are the exact requirements provided by Soulseek's administrators:

Basically the only thing the client needs to do is make sure that search results that contain any of the strings in message 160 in either their folder or file name aren't returned to other users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants