Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4.0 Text Off Set Under Columns #41

Closed
ghost opened this issue Feb 1, 2017 · 6 comments
Closed

1.4.0 Text Off Set Under Columns #41

ghost opened this issue Feb 1, 2017 · 6 comments

Comments

@ghost
Copy link

ghost commented Feb 1, 2017

I'm using Slackware 14.2 x86_64 with python-2.7.13.

I noticed under the Search and Downloads sections text is offset, meaning, for the given section text is not appearing directly underneath the section aligned under the first letter as some of the sections are.

Size under the Search Files the text is located more to the right, and right next to the text for Speed. The numbers should appear under the S, appearing as an example like below;

Size
9.5MB

In queue under the Search Files the text is also located more to the right, and right next to the text for Immediate Download

Same thing, text, the numbers for In queue don't appear lined up under the letter I as they should like below;

In queue
20

Length section the numbers are off set to the right and not appearing under, the letter L lined up like below as example;

Length
3:59

Please see the attached screen shot for what I mean.

It would be nice to have separation of the text, like how the other sections all appear. Not sure why these sections are like this, hmm...

nic

Thanks

@ghost
Copy link
Author

ghost commented Feb 1, 2017

Forgot to add in, for the Downloads section the Queue Position and Speed are what appear off for me, in the same way like the Search Files

You'll see below the 0 offset for the Queue Position and the 5.3 offset for the Speed , both of these over to the right;

nic

Thanks

@ghost ghost self-assigned this Feb 3, 2017
@ghost ghost added the enhancement label Feb 3, 2017
@ghost
Copy link

ghost commented Feb 3, 2017

Hi @Geyup,

Yes I think setting every columns "left align" should result in a more consistent UI.
It should not be too difficult to do (don't quote me on that :D) and I'll try to see how it looks and report back.

@ghost
Copy link

ghost commented Feb 4, 2017

I've pushed this tweaking in the develop branch of my own repo: https://github.com/gfarmerfr/nicotine-plus/tree/develop.
Could you check it out to see how it looks like ?
I think it's a little bit better, but taste and colours... :)

@ghost ghost closed this as completed in 304fe92 Feb 5, 2017
@ghost
Copy link
Author

ghost commented Feb 7, 2017

YEAH it's working nice, everything aligned to the left... :)

Can fonts or themes have an effect on this, I would think not, but I can test if you like?

THANKS gfarmerfr keep up the great work!

@ghost
Copy link

ghost commented Feb 7, 2017

Yes I would appreciate if you found out if themes would influence this. I don't this they would mess with gtk cell alignment but we never know. At least on the 2-3 themes I have on Gnome 3 I don't see any difference.

@ghost
Copy link
Author

ghost commented Feb 8, 2017

Ok will let know...

thanks

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

0 participants