regression on open files on OpenBSD

[hboetes]

Whilst downloading multiple albums (5) I ran into:

Major Socket Error: Networking terminated! [Errno 24] Too many open files

And all my downloads stopped. Might this be a regression from #346

[hboetes]

Ah, there's even a trace with that:

Thu 14:11 Major Socket Error: Networking terminated! [Errno 24] Too many open
          files
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/pynicotine/gtkgui/frame.py", line 1332, in updateLog
    AppendLine(self.LogWindow, msg, self.tag_log, scroll=shouldscroll)
  File "/usr/local/lib/python3.7/site-packages/pynicotine/gtkgui/utils.py", line 428, in AppendLine
    va = scrolledwindow.get_vadjustment()
AttributeError: 'NoneType' object has no attribute 'get_vadjustment'
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/pynicotine/gtkgui/frame.py", line 1332, in updateLog
    AppendLine(self.LogWindow, msg, self.tag_log, scroll=shouldscroll)
  File "/usr/local/lib/python3.7/site-packages/pynicotine/gtkgui/utils.py", line 428, in AppendLine
    va = scrolledwindow.get_vadjustment()
AttributeError: 'NoneType' object has no attribute 'get_vadjustment'
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/pynicotine/gtkgui/frame.py", line 1332, in updateLog
    AppendLine(self.LogWindow, msg, self.tag_log, scroll=shouldscroll)
  File "/usr/local/lib/python3.7/site-packages/pynicotine/gtkgui/utils.py", line 428, in AppendLine
    va = scrolledwindow.get_vadjustment()
AttributeError: 'NoneType' object has no attribute 'get_vadjustment'

[mathiascode]

Thanks for the trace! It's unrelated, but sometimes occurs when the program is shutting down.

[hboetes]

Ah, OK. I should check the terminal before shutting down.
Can I remove the trace?

[mathiascode]

Keep it, it's also an issue I want to fix.

[hboetes]

will reopen when it happens again, but since it doesn't happen that often anyway, it's hard to reproduce.