Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for Australia, Canada, Ethiopia, New Zealand, South Africa #189

Closed
salexgit opened this issue Dec 17, 2018 · 1 comment
Closed
Assignees

Comments

@salexgit
Copy link
Collaborator

Hi Nicu

While converting and testing LSSAH German campaign, I came across the problem that the game does not support properly certain countries: Australia, Canada, Ethiopia, New Zealand, South Africa. These nations are in the original EQP and NATIONS.txt file, and while editing SCN files everything works fine. However, converted scenarios do not work properly at all.

Firstly, I realized that you (for some reason) just hard-coded country names in the .JS script instead of e.g. generating automatically JSON file with country names and IDs. So, I extended the code which solved some of my problems.

countryNames="Slovakia;Belgium;Bulgaria;Czechoslovakia;Denmark;Finland;France;Germany;Greece;USA;Hungary;Turkey;Italy;Netherlands;Norway;Poland;Portugal;Romania;Croatia;Russia;Sweden;Allied Yugoslavia;United Kingdom;Yugoslavia;Nationalist Spain;Republican Spain;Australia;Canada;Ethiopia;New Zealand;South Africa".split(";")

However, another problem is that big country flags are missing for those countries in "resources/ui/flags". Again, I thought that those flags are added automatically by some conversion script because equipment JSON files are there for Australia, Canada, etc.

Can you please check it (asap) so that I can proceed with testing German LSSAH campaign? I am not sure whether other campaigns work properly. Some US scenarios have units from e.g. Canada, and they would just vanish from the scenario.

@nicupavel nicupavel self-assigned this Dec 30, 2018
@salexgit
Copy link
Collaborator Author

Hi Nicu

I tested quickly several scenarios where we have those nations, Australia, Canada, etc. Scenarios work fine except the fact that the "big" flag is missing, which is usually shown in the inspect window. Do you plan to add it? If you are busy, then if I have time, then I can try to find the corresponding flags on the Internet - it should not be that complex.

Regards, Alex

@salexgit salexgit closed this as completed Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants