Features branch #3
Conversation
…untries--react-capstone into build-project-branch
Build project branch
|
https://world-countries-react-redux.netlify.app/ - deploy link on netlify |
There was a problem hiding this comment.
STATUS: CHANGES REQUIRED ♻️ ♻️
Hi @nicupop729,
Good job so far!
✔️ Good video presentation
✔️ Nice UI design
✔️ Clean code
However, there are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
- While you added unit tests covering your components you are still missing integration tests using the React Testing Library as required in the project guidelines. Kindly add these. You can refer to this documentation and the recommended tutorial at the bottom of the article to get started.
- Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| import './countries.css'; | ||
| import DisplayCountries from './DisplayCountries'; | ||
|
|
||
| const Countries = ({ |
There was a problem hiding this comment.
- As stated in the project requirements, the
Details(here Countries) page should have a 'Back' button (<) which navigates the user to theHomepage. Kindly add this button as contained in the design template.
| import DisplayCountries from '../countries/DisplayCountries'; | ||
| import './country.css'; | ||
|
|
||
| const Country = ({ |
There was a problem hiding this comment.
- [OPTIONAL] It would be nice to add a 'Back' button to the
Countrypage as well.
|
✔️ Deploy Preview for world-countries-react-redux ready! 🔨 Explore the source changes: f2810cc 🔍 Inspect the deploy log: https://app.netlify.com/sites/world-countries-react-redux/deploys/61c5cf6e5d991d0007d9529d 😎 Browse the preview: https://deploy-preview-3--world-countries-react-redux.netlify.app |
There was a problem hiding this comment.
Status: Approved ✔️ ✔️ ✔️
Hi Nicu,
Congratulations 🎉 Thank you for implementing changes suggested previously 🙏
Please go ahead and merge the branch!
Happy Coding 👏👏👏
Please leave any questions or comments in the PR if you have any doubts or unclarity!
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
For this app, project requirements were followed and the next features were applied:
When the page loads, the web app shows the list of continents.
After the user chooses a continent, all the countries from that continent are displayed.
The user now can choose a country to receive information about it.
Anywhere in the app, the user can use the search bar, which will filter from 195 countries to display the country he searches for.
Technical set up:
Set up the repository on GitHub and use Gitflow;
Set up React and Redux;
Set up testing libraries;
We do not preserve user data;
The project is a single page application (SPA) built with React and Redux.
The data retrieved from the API is stored in the Redux store.
Every page (the main page and the pages for each item) have a unique route within the SPA.
link to presentations video