Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dirty code #7

Closed
Exagone313 opened this issue Aug 23, 2018 · 2 comments
Closed

Dirty code #7

Exagone313 opened this issue Aug 23, 2018 · 2 comments

Comments

@Exagone313
Copy link
Contributor

Hi,

The whole code is dirty, I easily found XSS vulnerabilities (see #6).
To make the code properly maintainable, the least is to have layout (HTML, templates) separated from computation, but each kind of "component" should be clearly separated (abstraction). Also, code is written with weird PHP practices (like @$var, == instead of === when inappropriate, etc...).

If someone is willing to rewrite everything, users would surely appreciate.

@nidebr
Copy link
Owner

nidebr commented Sep 7, 2018

Hi,

A few months ago I started working on a new release based on a framework and redo code a little cleaner, but I have not had time to really put back, I must look to that.

Thank you for your contribution.

@dermalikmann
Copy link

Hey there!
Thank you very much for the new UI! Just wanted to make an addition:
If you are currently working on a redo I wanted to ask if you could stick more to the original template of AdminLTE. I personally think that it's more appealing to the eye. It's not that the current color scheme is ugly after all, but what's the point of using a template when only very few of its aspects are used? 😅
But as I said: It's just a personal note.

Again thank you for your work.

Oh and by the way: If you are working on a redo, just push your changes to another branch. I would love to give a helping hand if I can ^^

@nidebr nidebr closed this as completed Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants