Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support for libretranslate.com #106

Closed
fcolecumberri opened this issue Sep 29, 2021 · 12 comments · Fixed by #115
Closed

[Feature Request] Support for libretranslate.com #106

fcolecumberri opened this issue Sep 29, 2021 · 12 comments · Fixed by #115
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed

Comments

@fcolecumberri
Copy link
Contributor

Description

Support for https://libretranslate.com/

Also, I think in this case, the construct should have the url as parameter, since as described at https://github.com/LibreTranslate/LibreTranslate#mirrors , the project can be used locally or by other servers.

@nidhaloff nidhaloff added enhancement New feature or request good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed labels Oct 7, 2021
@nidhaloff
Copy link
Owner

Hi @fcolecumberri Thanks for this feature request. I think it looks good and we can integrate it easily in DT.

I think this is a perfect issue for new contributors (or yourself), if you want to contribute. I will give a chance for new people to join the project through this issue, otherwise I will check it out myself asap.

@ridicolos
Copy link

ridicolos commented Oct 29, 2021

Hey @nidhaloff I am really new to contributing to open-source projects, but would love to help out here.

Could I take this issue? If all goes according to plan, I should be able to work on this in the next week. Hopefully it won't take too long for me to implement.

@nidhaloff
Copy link
Owner

@ridicolos Sure, just make a PR ;)

@nidhaloff
Copy link
Owner

@ridicolos Any progress on this feature?

@ridicolos
Copy link

ridicolos commented Nov 19, 2021

@nidhaloff unfortunately not yet. If you want to take over the issue right away, you can. I'm not sure how soon I'll get to it.

I'll probably manage to work on it a bit on sunday, but probably won't be able to finish it then.

But if you want to jump right into it, feel free to do that :)

@rahulbanerjee26
Copy link
Contributor

rahulbanerjee26 commented Dec 6, 2021

Hi! Is this issue up for grabs? I am interested in adding support for libretranslate

@ridicolos
Copy link

Hey @rahulbanerjee26, because I unfortunately still haven't got around to starting the issue i don't think anything stands in the way and you can start with the implementation

@rahulbanerjee26
Copy link
Contributor

Thanks, @ridicolos

@nidhaloff could you please assign the issue to me? I should have a PR out in a week or so, thanks!

@nidhaloff
Copy link
Owner

Hi @rahulbanerjee26 thanks for joining. Normally I'm against assigning issues to specific people and I would prefer that anyone can work on it and just make a PR if something is ready. However, I would assign the issue to you in this case if you keep us updated about findings, changes, etc... ;)

@rahulbanerjee26
Copy link
Contributor

rahulbanerjee26 commented Dec 8, 2021

Hi! @nidhaloff thank you!
Just to give you a bit of context, one of my courses in my university requires me to make an open-source contribution. I am a part of a team of 5 and the entire team will work together on making the PR.

We found an API Wrapper for libretranslate and are investigating it to see if it can be used. If the wrapper has any limitations, we plan on consuming the API directly instead.

@nidhaloff
Copy link
Owner

@rahulbanerjee26 Sounds great. I'd rather not add a dependency/lib. The wrapper does not look mature and therefore, it would be great if you guys can make use of the existing dependencies. As you said, calling the API directly should be straightforward

@rahulbanerjee26
Copy link
Contributor

Hi! @nidhaloff, we just made a PR for this feature.

@nidhaloff nidhaloff linked a pull request Dec 22, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants