New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Support for libretranslate.com #106
Comments
Hi @fcolecumberri Thanks for this feature request. I think it looks good and we can integrate it easily in DT. I think this is a perfect issue for new contributors (or yourself), if you want to contribute. I will give a chance for new people to join the project through this issue, otherwise I will check it out myself asap. |
Hey @nidhaloff I am really new to contributing to open-source projects, but would love to help out here. Could I take this issue? If all goes according to plan, I should be able to work on this in the next week. Hopefully it won't take too long for me to implement. |
@ridicolos Sure, just make a PR ;) |
@ridicolos Any progress on this feature? |
@nidhaloff unfortunately not yet. If you want to take over the issue right away, you can. I'm not sure how soon I'll get to it. I'll probably manage to work on it a bit on sunday, but probably won't be able to finish it then. But if you want to jump right into it, feel free to do that :) |
Hi! Is this issue up for grabs? I am interested in adding support for libretranslate |
Hey @rahulbanerjee26, because I unfortunately still haven't got around to starting the issue i don't think anything stands in the way and you can start with the implementation |
Thanks, @ridicolos @nidhaloff could you please assign the issue to me? I should have a PR out in a week or so, thanks! |
Hi @rahulbanerjee26 thanks for joining. Normally I'm against assigning issues to specific people and I would prefer that anyone can work on it and just make a PR if something is ready. However, I would assign the issue to you in this case if you keep us updated about findings, changes, etc... ;) |
Hi! @nidhaloff thank you! We found an API Wrapper for libretranslate and are investigating it to see if it can be used. If the wrapper has any limitations, we plan on consuming the API directly instead. |
@rahulbanerjee26 Sounds great. I'd rather not add a dependency/lib. The wrapper does not look mature and therefore, it would be great if you guys can make use of the existing dependencies. As you said, calling the API directly should be straightforward |
Hi! @nidhaloff, we just made a PR for this feature. |
Description
Support for https://libretranslate.com/
Also, I think in this case, the construct should have the url as parameter, since as described at https://github.com/LibreTranslate/LibreTranslate#mirrors , the project can be used locally or by other servers.
The text was updated successfully, but these errors were encountered: