Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review #12

Open
AngelaBubble opened this issue Feb 20, 2018 · 1 comment
Open

Code review #12

AngelaBubble opened this issue Feb 20, 2018 · 1 comment

Comments

@AngelaBubble
Copy link
Collaborator

Data path is clear and well organized. But whats the different for pictures in resized and results file?
All API calls works well. But the vision API didn't apply on the image get from twitter.

The major problem in your code is that you really should hide your twitter API keys.

I ran through three error cases: invalid twitter handle, twitter account with no photos, and invalid google vision api auth. For the first one and the second one, the program just returns the default error shown through terminal by twitter. You should insert a 'try' to show which error you are handling. The third one, it would get default error returned by google vision. You should do the same thing for google vision api.

@AngelaBubble
Copy link
Collaborator Author

Perfromance:

For google vision api, it also write what google vision api returns on the pictures, which is quite awesome.

For twitter api and ffmpeg is general works good excepts some extreme condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant