Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong agent name on several UserAgent Strings #84

Closed
krejzus opened this issue May 23, 2018 · 8 comments
Closed

Wrong agent name on several UserAgent Strings #84

krejzus opened this issue May 23, 2018 · 8 comments

Comments

@krejzus
Copy link

krejzus commented May 23, 2018

  1. UA: SAMSUNG-GT-S5610-ORANGE/S5610BVKL1 NetFront/4.1 Profile/MIDP-2.0 Configuration/CLDC-1.1

AgentName is: SAMSUNG-GT-S5610-ORANGE
should be: NetFront 4.1


  1. UserAgent vs 1password
    For user-agent:
  • Mozilla/5.0 (iPhone; CPU OS 11_4 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) 1Password/7.0.6 (like Version/11.4 Mobile/15F5049c Safari/600.1.4)

we get:
AgentClass=Browser;
AgentName=1Password;
AgentVersion=7.0.6;
AgentVersionMajor=7;
AgentNameVersion=1Password 7.0.6;
AgentNameVersionMajor=1Password 7;

and the same

  • Mozilla/5.0 (iPad; CPU OS 11_3 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) 1Password/7.0.6 (like Version/11.3 Mobile/15E216 Safari/600.1.4

These are Safari 11.4 and 11.3


  1. UA: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 OWASMIME/4.0500
    AgentName is OWASMIME, please verify if it's ok.

  1. Lenovo-A820/S100 Linux/3.4.0 Android/4.1 Release/11.14.2012 Browser/AppleWebKit534.30 Profile/ Configuration/ Safari/534.30

we get:
AgentName=Lenovo-A820;
AgentVersion=S100;
AgentVersionMajor=S100;
AgentNameVersion=Lenovo-A820 S100;
AgentNameVersionMajor=Lenovo-A820 S100;


yauaa v. 4.3

These are production examples.

@krejzus krejzus changed the title UserAgent vs 1password Wrong agent name on several UserAgent Strings May 23, 2018
@nielsbasjes
Copy link
Owner

I had a look at those examples:

  1. I'll look into the SAMSUNG-GT-S5610-ORANGE case.
  2. As far as I know 1password on iOS has a built in browser so the two 1password look good to me.
  3. The OWASMIME turns out to be a plugin that causes problems all over the place. I'll look into that one. Specific user agent string causes infinite loop in  arouel/uadetector#132 https://support.mozilla.org/nl/questions/1190816
  4. The Lenovo useragents are known to make a mess of things. Because there is no indication of the actual browser application this is currently the best I can do. If you have information about the actual browser used on these devices I welcome that info.

@krejzus
Copy link
Author

krejzus commented May 23, 2018

  1. Thank you.
  2. This is good information- thank you for comment.
  3. OK
  4. Unfortunately this is from log file and I don't actually know any details. 3'rd party tools says this is "Android Browser" :<

@krejzus
Copy link
Author

krejzus commented May 23, 2018

  1. One more UA: Mozilla/5.0 (FreeBSD; Viera; rv:34.0) Gecko/20100101 Firefox/34.0

Isn't it Firefox 34 on FreeBSD (Firefo OS on VieraTV)?

@nielsbasjes
Copy link
Owner

  1. Samsung/Netfront case: Fixed.
  2. Lenovo; Yes, reporting the stock browser makes a lot more sense. Fixed.
  3. I'll have a look. Seems to be a Panasonic TV: http://thadafinser.github.io/UserAgentParserComparison/v4/user-agent-detail/ce/71/ce710618-578f-4c06-bb21-240e261b3ca5.html

@nielsbasjes
Copy link
Owner

I changes the Viera detection a bit.
I deployed the latest snapshot here https://analyze-useragent.appspot.com/
Can you check if the results are good now?

@krejzus
Copy link
Author

krejzus commented May 24, 2018

Now it looks good.
P.S. awesome lib - I've been looking for that tool for a few days. I've tested a lot of libs and actually comparing to yours they were "poor".
Thank you for the lib and quick response, fix and explenations.
I can't wait for release at Maven :)

@krejzus
Copy link
Author

krejzus commented May 24, 2018

Only FYI:
SAMSUNG-GT-S5610-ORANGE -> ORANGE stands for cellular (mobile) operator.

@nielsbasjes
Copy link
Owner

Yes, I already guessed that orange was the operator.
I just released version 4.4 to maven.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants