Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to arm not showing up as a notification anymore #20

Closed
xhemp opened this issue Nov 20, 2020 · 5 comments
Closed

Failed to arm not showing up as a notification anymore #20

xhemp opened this issue Nov 20, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@xhemp
Copy link

xhemp commented Nov 20, 2020

I'm using the latest 1.1.2, just wondering if there was any change on notifications (on purpose or not) as I haven't been able to see the failed to arm notifications anymore, other notifications look ok ie: If I try to arm the alarm with a sensor open, it doesn't work and it also doesn't show me anything even though I have a notification set.

@issue-label-bot issue-label-bot bot added the bug Something isn't working label Nov 20, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.58. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@nielsfaber
Copy link
Owner

I will take a look. This is not intentional.

@nielsfaber
Copy link
Owner

I saw that a bug that causes no notification to be sent if:

  1. You have a leave delay > 0, and
  2. There is a sensor open, which is configured to trigger immediate

This is a special case since such sensors are evaluated at the start of the arming process, where others are evaluated at the end of the arming process (so when leave delay has expired).

I also added some logging for these scenario's.

I'm assuming that this scenario is what you were encountering.
For other scenario's I was not able to reproduce the issue.
The bug is patched and will be included in the upcoming release.

@nielsfaber
Copy link
Owner

This is fixed in release v1.2.0.
Please update and test if the issue is resolved.
Close the issue if this is the case, otherwise let me know!

@xhemp
Copy link
Author

xhemp commented Nov 23, 2020

I tested with different scenarios and they are now all working as expected now, @nielsfaber , thanks!

@xhemp xhemp closed this as completed Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants