Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in blnet_web.py #37

Closed
whatashit opened this issue Apr 26, 2023 · 3 comments · Fixed by #38
Closed

Bug in blnet_web.py #37

whatashit opened this issue Apr 26, 2023 · 3 comments · Fixed by #38

Comments

@whatashit
Copy link

After having some issues with a UVR1611 not being node 1 I found out that there is most probably a bug in blnet_web.py

Line 166. In def set_node(self, node):

The http request changes the node number of the BLNET not the UVR1611.

self.ip + "/can.htm?blaA=" + str(node)

should be changed to

self.ip + "/can.htm?blaB=" + str(node)

@nielstron
Copy link
Owner

Thanks for raising this! I will incorporate this change. I am wondering if anyone else has experienced this issue as well?

@whatashit
Copy link
Author

@nielstron
I guess the UVR1611 and BLNET are not so common anymore as new heating systems have usually very good control possibilities and also network integration. But I still love the UVR.
I came accross that issue because of the need to change to a different node. And I saw connection is only possible after manual selection and the next couple of hours.
I still have some issues. So maybe I need to dig into this deeper again some day.

@whatashit
Copy link
Author

@nielstron

Hello Niels,

looks like you fixed the bug. What are the next steps to get this version. HA picks the version automatically (I guess based on some request in the BLNET integration).
This bug-fix would also fix the issue we are having loosing the connection to UVR1611. As right now you cannot define a node in the configuration. If no node is provided the module "set_node" will never be executed. This small fix would really help.

There is now a pull request. Can I do anything or provide some help? Sorry I'm new to Github....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants