Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] - Don't download cache if it exists #36

Open
Tracked by #52
calvinbui opened this issue Sep 20, 2021 · 9 comments
Open
Tracked by #52

[FEATURE REQUEST] - Don't download cache if it exists #36

calvinbui opened this issue Sep 20, 2021 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@calvinbui
Copy link

By editing Buildkite's git-clean-flags we can exclude cache files or directories from being removed during checkout. If this is so, this plugin could check if the cache files/folders already exist and skip restoring it.

This could be done with a key like skip_restore_existing or something.

@gencer gencer added the enhancement New feature or request label Sep 20, 2021
@gencer gencer self-assigned this Sep 20, 2021
@gencer
Copy link
Collaborator

gencer commented Sep 21, 2021

Yup! Great idea.

I will prepare after other pending bug.

@gencer
Copy link
Collaborator

gencer commented Sep 24, 2021

I've evaluated possible use cases and, I'm not sure If checking existing directories are reliable or not. For example, you may change cache folders on next builds which leads to incorrect match. However, It is still possible to do so. I'll handle this on v2.5.0. Feel free to send your PR if you have any proposal.

@stale
Copy link

stale bot commented Oct 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 14, 2021
@gencer
Copy link
Collaborator

gencer commented Oct 14, 2021

Not stale.

@stale stale bot removed the wontfix This will not be worked on label Oct 14, 2021
@stale
Copy link

stale bot commented Nov 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 3, 2021
@stale stale bot closed this as completed Nov 7, 2021
@gencer gencer reopened this Nov 7, 2021
@stale stale bot removed the wontfix This will not be worked on label Nov 7, 2021
@stale
Copy link

stale bot commented Nov 29, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 29, 2021
@stale stale bot closed this as completed Dec 2, 2021
@gencer gencer reopened this Dec 3, 2021
@stale stale bot removed the wontfix This will not be worked on label Dec 3, 2021
@stale
Copy link

stale bot commented Dec 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 24, 2021
@gencer gencer added wontfix This will not be worked on and removed wontfix This will not be worked on labels Dec 24, 2021
@gencer
Copy link
Collaborator

gencer commented Dec 24, 2021

Not stale

@stale stale bot removed the wontfix This will not be worked on label Dec 24, 2021
@stale
Copy link

stale bot commented Jan 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 13, 2022
@stale stale bot closed this as completed Jan 16, 2022
@gencer gencer reopened this Aug 12, 2022
@stale stale bot removed the wontfix This will not be worked on label Aug 12, 2022
@gencer gencer mentioned this issue Aug 29, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants